Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Gradle dependencies improv #224

Merged
merged 6 commits into from
Oct 22, 2024
Merged

Gradle dependencies improv #224

merged 6 commits into from
Oct 22, 2024

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais had a problem deploying to docker-build-and-e2e October 22, 2024 11:31 — with GitHub Actions Failure
# Conflicts:
#	buildSrc/src/main/groovy/net.consensys.zkevm.kotlin-common-conventions.gradle
#	gradle/libs.versions.toml
#	jvm-libs/linea/core/domain-models/build.gradle
@codecov-commenter
Copy link

codecov-commenter commented Oct 22, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.04%. Comparing base (04857a0) to head (05451b0).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #224      +/-   ##
============================================
- Coverage     71.21%   71.04%   -0.17%     
+ Complexity     1074     1073       -1     
============================================
  Files           291      291              
  Lines         11966    11965       -1     
  Branches       1050     1050              
============================================
- Hits           8521     8501      -20     
- Misses         2973     2989      +16     
- Partials        472      475       +3     
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from 04857a0
kotlin 68.77% <ø> (-0.18%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
.../clients/prover/serialization/JsonSerialization.kt 66.66% <ø> (-13.34%) ⬇️

... and 1 file with indirect coverage changes

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 22, 2024 11:44 — with GitHub Actions Inactive
@jpnovais jpnovais merged commit ea017bb into main Oct 22, 2024
25 checks passed
@jpnovais jpnovais deleted the gradle-dependencies-improv branch October 22, 2024 12:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants