Blob Decompressor and Some Helpers #230
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnovais
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #230 +/- ##
=========================================
Coverage 71.01% 71.01%
- Complexity 1074 1075 +1
=========================================
Files 292 296 +4
Lines 12017 12055 +38
Branches 1058 1063 +5
=========================================
+ Hits 8534 8561 +27
- Misses 3004 3015 +11
Partials 479 479
*This pull request uses carry forward flags. Click here to find out more.
|
jpnovais
force-pushed
the
coordinator-code-reuse-1
branch
from
00bd24f to
3e02856
Compare
jpnovais
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
jpnovais
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
jpnovais
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
jonesho
reviewed
Oct 23, 2024
...ibs/linea/blob-compressor/src/main/kotlin/net/consensys/linea/blob/GoNativeBlobCompressor.kt
Show resolved
Hide resolved
jonesho
reviewed
Oct 23, 2024
...linea/blob-decompressor/src/main/kotlin/net/consensys/linea/blob/GoNativeBlobDecompressor.kt
Show resolved
Hide resolved
jonesho
reviewed
Oct 23, 2024
|
@jonesho questions addressed. Please take a 2nd look. |
jpnovais
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
jonesho
previously approved these changes
Oct 23, 2024
jpnovais
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
jonesho
approved these changes
Oct 23, 2024
jonesho
reviewed
Oct 23, 2024
| } | ||
| rlpWriter.endList() | ||
| }.toArray() | ||
| } |
There was a problem hiding this comment.
@jpnovais A late question, not a blocker to this PR, why not put them in ByteArrayExtension?
There was a problem hiding this comment.
Because generic/extensions/XYZ, must be vanila packages that do not bring extra dependencies. To do that, I would need to add Besu libraries to generic/extensions/kotlin.
Filter94
reviewed
Oct 23, 2024
...a/blob-decompressor/src/test/kotlin/net/consensys/linea/blob/GoNativeBlobDecompressorTest.kt
Show resolved
Hide resolved
Filter94
reviewed
Oct 23, 2024
...ob-decompressor/src/test/kotlin/net/consensys/linea/blob/BlobDecompressorDataDecodingTest.kt
Show resolved
Hide resolved
Filter94
reviewed
Oct 23, 2024
Filter94
reviewed
Oct 23, 2024
jvm-libs/generic/extensions/kotlin/src/main/kotlin/build/linea/URIExtensions.kt
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist