Coordinator: generic upstream client interface #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jpnovais
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
jpnovais
force-pushed
the
coordinator-code-reuse-2
branch
from
1aefad5 to
dd3e8b8
Compare
jpnovais
force-pushed
the
coordinator-code-reuse-3
branch
from
14b9f70 to
7ad31ba
Compare
jpnovais
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Failure
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
============================================
+ Coverage 70.76% 70.87% +0.11%
- Complexity 1074 1075 +1
============================================
Files 298 299 +1
Lines 12070 12078 +8
Branches 1068 1070 +2
============================================
+ Hits 8541 8560 +19
+ Misses 3049 3042 -7
+ Partials 480 476 -4
*This pull request uses carry forward flags. Click here to find out more.
|
jonesho
previously approved these changes
Oct 23, 2024
jpnovais
force-pushed
the
coordinator-code-reuse-2
branch
from
8deb66f to
d40aa4d
Compare
# Conflicts: # jvm-libs/generic/extensions/kotlin/src/test/kotlin/build/linea/URIExtensionsTest.kt # jvm-libs/generic/vertx-helper/src/main/kotlin/net/consensys/linea/vertx/ClientOptions.kt # jvm-libs/linea/blob-decompressor/src/test/kotlin/net/consensys/linea/blob/BlobDecompressorDataDecodingTest.kt # jvm-libs/linea/blob-decompressor/src/test/kotlin/net/consensys/linea/blob/GoNativeBlobDecompressorTest.kt
jpnovais
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
I discussed that in our coordinator meetings: The idea is for the Request class implements |
Filter94
approved these changes
Oct 23, 2024
jonesho
approved these changes
Oct 23, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements issue(s) #
Checklist