Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

removes unused class #235

Merged
merged 1 commit into from
Oct 23, 2024
Merged

removes unused class #235

merged 1 commit into from
Oct 23, 2024

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team October 23, 2024 12:03
@jpnovais jpnovais had a problem deploying to docker-build-and-e2e October 23, 2024 12:05 — with GitHub Actions Failure
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.62%. Comparing base (baffb9c) to head (a7cc7b9).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #235      +/-   ##
============================================
+ Coverage     70.25%   70.62%   +0.37%     
  Complexity     1074     1074              
============================================
  Files           301      300       -1     
  Lines         12158    12108      -50     
  Branches       1079     1073       -6     
============================================
+ Hits           8541     8551      +10     
+ Misses         3137     3079      -58     
+ Partials        480      478       -2     
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from baffb9c
kotlin 68.34% <ø> (+0.39%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

see 2 files with indirect coverage changes

@jpnovais jpnovais merged commit 807d6c5 into main Oct 23, 2024
11 of 12 checks passed
@jpnovais jpnovais deleted the coordinator-remove-deadcode branch October 23, 2024 13:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants