Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Limiting number of concurrent traces API requests for the local stack… #236

Merged
merged 8 commits into from
Oct 25, 2024

Conversation

Filter94
Copy link
Collaborator

… to avoid occasional OOM-s

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Filter94 Filter94 had a problem deploying to docker-build-and-e2e October 23, 2024 13:59 — with GitHub Actions Failure
@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 23, 2024 14:02 — with GitHub Actions Inactive
jpnovais
jpnovais previously approved these changes Oct 23, 2024
Copy link
Collaborator

@jpnovais jpnovais left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Ok to me. Please just check if it does not slow down the e2e tests

@Filter94
Copy link
Collaborator Author

Ok to me. Please just check if it does not slow down the e2e tests

Of course, I will give it a couple of tries

@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 71.68%. Comparing base (011de09) to head (ef1c4d3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #236   +/-   ##
=========================================
  Coverage     71.68%   71.68%           
  Complexity     1086     1086           
=========================================
  Files           299      299           
  Lines         12140    12140           
  Branches       1082     1082           
=========================================
  Hits           8702     8702           
  Misses         2948     2948           
  Partials        490      490           
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from 6569485
kotlin 69.49% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 23, 2024 14:43 — with GitHub Actions Inactive
VGau
VGau previously approved these changes Oct 23, 2024
@Filter94 Filter94 dismissed stale reviews from VGau and jpnovais via 6c6f237 October 23, 2024 17:40
@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 23, 2024 17:41 — with GitHub Actions Inactive
@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 23, 2024 18:04 — with GitHub Actions Inactive
@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 23, 2024 18:28 — with GitHub Actions Inactive
…m:Consensys/linea-monorepo into trying-to-increase-stability-of-the-stack
@Filter94 Filter94 temporarily deployed to docker-build-and-e2e October 25, 2024 08:10 — with GitHub Actions Inactive
@Filter94 Filter94 merged commit 8600745 into main Oct 25, 2024
21 checks passed
@Filter94 Filter94 deleted the trying-to-increase-stability-of-the-stack branch October 25, 2024 09:44
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants