Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Coordinator use new state manager #237

Merged
merged 7 commits into from
Oct 24, 2024
Merged

Conversation

jpnovais
Copy link
Collaborator

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team October 23, 2024 18:01
@jpnovais jpnovais had a problem deploying to docker-build-and-e2e October 23, 2024 18:03 — with GitHub Actions Failure
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 23, 2024 18:07 — with GitHub Actions Inactive
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 57.35294% with 29 lines in your changes missing coverage. Please review.

Project coverage is 71.33%. Comparing base (807d6c5) to head (8f72f9f).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...ereum/coordination/blob/BlobZkStateProviderImpl.kt 0.00% 8 Missing ⚠️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 0.00% 7 Missing ⚠️
...kotlin/build/linea/clients/StateManagerClientV1.kt 0.00% 7 Missing ⚠️
...ea/jsonrpc/client/VertxHttpJsonRpcClientFactory.kt 76.92% 2 Missing and 1 partial ⚠️
...tion/conflation/TracesConflationCoordinatorImpl.kt 0.00% 2 Missing ⚠️
...linea/jsonrpc/client/LoadBalancingJsonRpcClient.kt 87.50% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #237      +/-   ##
============================================
+ Coverage     70.54%   71.33%   +0.79%     
- Complexity     1074     1077       +3     
============================================
  Files           300      298       -2     
  Lines         12108    12038      -70     
  Branches       1073     1073              
============================================
+ Hits           8541     8587      +46     
+ Misses         3087     2964     -123     
- Partials        480      487       +7     
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from f5d35bf
kotlin 69.10% <57.35%> (+0.84%) ⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...clients/prover/FileBasedExecutionProverClientV2.kt 59.01% <100.00%> (ø)
...tor/clients/BatchExecutionProverRequestResponse.kt 44.44% <ø> (ø)
...dination/conflation/TracesConflationCoordinator.kt 0.00% <ø> (ø)
...ys/linea/jsonrpc/client/JsonRpcRequestRetryerV2.kt 84.78% <ø> (+18.82%) ⬆️
...build/linea/clients/StateManagerV1JsonRpcClient.kt 96.72% <100.00%> (+96.72%) ⬆️
...face/src/main/kotlin/build/linea/clients/Client.kt 0.00% <ø> (ø)
...tion/conflation/TracesConflationCoordinatorImpl.kt 44.44% <0.00%> (+8.08%) ⬆️
...linea/jsonrpc/client/LoadBalancingJsonRpcClient.kt 87.09% <87.50%> (+0.65%) ⬆️
...ea/jsonrpc/client/VertxHttpJsonRpcClientFactory.kt 73.42% <76.92%> (+15.97%) ⬆️
.../consensys/zkevm/coordinator/app/L1DependentApp.kt 1.58% <0.00%> (+0.01%) ⬆️
... and 2 more

... and 3 files with indirect coverage changes

jonesho
jonesho previously approved these changes Oct 24, 2024
@jpnovais jpnovais requested a review from jonesho October 24, 2024 09:33
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 24, 2024 09:34 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 24, 2024 09:48 — with GitHub Actions Inactive
@jpnovais jpnovais merged commit e71ec80 into main Oct 24, 2024
25 checks passed
@jpnovais jpnovais deleted the coordinator-use-new-state-manager branch October 24, 2024 10:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants