Skip to content

State recover: Blobscan and Execution Layer client #238

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 11 commits into from
Oct 25, 2024
Merged

Conversation

jpnovais
Copy link
Contributor

@jpnovais jpnovais commented Oct 23, 2024

Note

Need to define

group = 'build.linea.staterecover'

because of this issue

Otherwise, if a module depends on jvm-libs:linea:core:domain-models and staterecover:appcore:domain-models it will have issues, only one gets imported because both have same end module domain-models

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@jpnovais jpnovais requested a review from a team October 23, 2024 23:23
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 23, 2024 23:24 — with GitHub Actions Inactive
@jpnovais jpnovais had a problem deploying to docker-build-and-e2e October 23, 2024 23:33 — with GitHub Actions Failure
@codecov-commenter
Copy link

codecov-commenter commented Oct 23, 2024

Codecov Report

Attention: Patch coverage is 60.00000% with 2 lines in your changes missing coverage. Please review.

Project coverage is 71.66%. Comparing base (24366fc) to head (b949b89).
Report is 3 commits behind head on main.

Current head b949b89 differs from pull request most recent head 6786c65

Please upload reports for the commit 6786c65 to get more accurate results.

Files with missing lines Patch % Lines
...c/main/kotlin/net/consensys/ByteArrayExtensions.kt 60.00% 1 Missing and 1 partial ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #238      +/-   ##
============================================
- Coverage     71.68%   71.66%   -0.02%     
+ Complexity     1086     1085       -1     
============================================
  Files           299      299              
  Lines         12140    12145       +5     
  Branches       1082     1083       +1     
============================================
+ Hits           8702     8704       +2     
- Misses         2948     2949       +1     
- Partials        490      492       +2     
Flag Coverage Δ *Carryforward flag
hardhat 98.67% <ø> (ø) Carriedforward from cc438a6
kotlin 69.48% <60.00%> (-0.02%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...c/main/kotlin/net/consensys/ByteArrayExtensions.kt 84.84% <60.00%> (-4.44%) ⬇️

... and 1 file with indirect coverage changes

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 24, 2024 10:02 — with GitHub Actions Inactive
@jpnovais jpnovais requested a review from jonesho October 24, 2024 10:19
@jpnovais jpnovais had a problem deploying to docker-build-and-e2e October 24, 2024 10:22 — with GitHub Actions Failure
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 24, 2024 16:37 — with GitHub Actions Inactive
@jpnovais jpnovais temporarily deployed to docker-build-and-e2e October 24, 2024 21:10 — with GitHub Actions Inactive
jonesho
jonesho previously approved these changes Oct 25, 2024
Copy link
Contributor

@jonesho jonesho left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, with minor suggestions

@jpnovais
Copy link
Contributor Author

@jonesho addressed your feedback. Please take a look, thanks.

@jpnovais jpnovais had a problem deploying to docker-build-and-e2e October 25, 2024 09:54 — with GitHub Actions Failure
@jpnovais jpnovais merged commit 81ad2ce into main Oct 25, 2024
10 of 12 checks passed
@jpnovais jpnovais deleted the state-revover-p1 branch October 25, 2024 09:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants