-
Notifications
You must be signed in to change notification settings - Fork 85
State recover: Blobscan and Execution Layer client #238
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Codecov ReportAttention: Patch coverage is
Additional details and impacted files@@ Coverage Diff @@
## main #238 +/- ##
============================================
- Coverage 71.68% 71.66% -0.02%
+ Complexity 1086 1085 -1
============================================
Files 299 299
Lines 12140 12145 +5
Branches 1082 1083 +1
============================================
+ Hits 8702 8704 +2
- Misses 2948 2949 +1
- Partials 490 492 +2
*This pull request uses carry forward flags. Click here to find out more.
|
3d55a9a
to
e68db1a
Compare
e33301d
to
4f104ac
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, with minor suggestions
...layer-json-rpc-client/src/main/kotlin/build/linea/staterecover/clients/el/ELJsonRpcClient.kt
Outdated
Show resolved
Hide resolved
jvm-libs/generic/extensions/kotlin/src/test/kotlin/net/consensys/ByteArrayExtensionsTest.kt
Show resolved
Hide resolved
@jonesho addressed your feedback. Please take a look, thanks. |
Note
Need to define
because of this issue
Otherwise, if a module depends on
jvm-libs:linea:core:domain-models
andstaterecover:appcore:domain-models
it will have issues, only one gets imported because both have same end moduledomain-models
Checklist