Extend MetricsFacade with createSimpleTimer() factory

[bradbown]

This PR implements issue(s) #2963
Adds:

• Add metrics to capture the time to compress data (time spent in method GoBackedBlobCompressor canAppendBlock and appendBlock)
• Add metrics to capture the time to perform shnarf calculation (time spent in GoBackedBlobShnarfCalculator calculateShnarf)
• Add metrics to capture the compression ratio
• Add metrics to capture the blob utilization ratio

Checklist

• I wrote new tests for my new core changes.
• I have successfully ran tests, style checker and build against my new changes locally.
• I have informed the team of any breaking changes if there are any.

[codecov-commenter]

Codecov Report

Attention: Patch coverage is 92.51337% with 14 lines in your changes missing coverage. Please review.

Project coverage is 68.46%. Comparing base (574e0ef) to head (21a83fd).

Files with missing lines	Patch %	Lines
.../consensys/zkevm/coordinator/app/L1DependentApp.kt	0.00%	6 Missing ⚠️
.../consensys/zkevm/coordinator/app/CoordinatorApp.kt	0.00%	3 Missing ⚠️
...consensys/linea/jsonrpc/JsonRpcMessageProcessor.kt	96.66%	2 Missing ⚠️
...ordination/blob/BlobCompressionProofCoordinator.kt	85.71%	1 Missing ⚠️
...linea/metrics/micrometer/DynamicTagTimerCapture.kt	75.00%	1 Missing ⚠️
...inea/metrics/micrometer/MicrometerMetricsFacade.kt	96.96%	0 Missing and 1 partial ⚠️

Additional details and impacted files

@@             Coverage Diff              @@
##               main     #265      +/-   ##
============================================
+ Coverage     68.21%   68.46%   +0.25%     
- Complexity     1128     1149      +21     
============================================
  Files           319      319              
  Lines         12846    12930      +84     
  Branches       1291     1296       +5     
============================================
+ Hits           8763     8853      +90     
+ Misses         3552     3545       -7     
- Partials        531      532       +1     

Flag	Coverage Δ		*Carryforward flag
hardhat	98.74% <ø> (ø)		Carriedforward from 574e0ef
kotlin	66.04% <92.51%> (+0.29%)	⬆️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines	Coverage Δ
...zkevm/ethereum/coordination/blob/BlobCompressor.kt	91.83% <100.00%> (+2.79%)	⬆️
.../ethereum/coordination/blob/BlobShnarfCalulator.kt	76.19% <100.00%> (+1.83%)	⬆️
...m/coordination/conflation/ConflationServiceImpl.kt	82.19% <100.00%> (ø)
...sys/linea/jsonrpc/client/VertxHttpJsonRpcClient.kt	97.24% <100.00%> (+0.02%)	⬆️
...ea/jsonrpc/client/VertxHttpJsonRpcClientFactory.kt	73.42% <100.00%> (ø)
...otlin/net/consensys/linea/metrics/MetricsFacade.kt	100.00% <100.00%> (+14.28%)	⬆️
...s/linea/metrics/micrometer/AbstractTimerCapture.kt	100.00% <ø> (+19.04%)	⬆️
...sys/linea/metrics/micrometer/SimpleTimerCapture.kt	100.00% <100.00%> (+5.88%)	⬆️
...ordination/blob/BlobCompressionProofCoordinator.kt	93.54% <85.71%> (ø)
...linea/metrics/micrometer/DynamicTagTimerCapture.kt	81.81% <75.00%> (-3.04%)	⬇️
... and 4 more

... and 3 files with indirect coverage changes

[jonesho]

From Bradley's previous changes, JsonRpcMessageProcessor needed to be passed in both metricsFacade and metricsRegistry, and here I further reduced it to just pass in metricsFacade and added createDynamicTagTimer in MetricsFacade class

[jpnovais]

I don't have bandwidth to review this pr atm. But please don't merge for now as is believe it will introduce breaking changes to the metrics.

[jonesho]

I don't have bandwidth to review this pr atm. But please don't merge for now as is believe it will introduce breaking changes to the metrics.

@jpnovais the changes here should have taken care of not introducing breaking changes to existing metrics

[jpnovais]

@jonesho I still see a lot of diff changes in the JSON-RPC area, It's hard by looking at the code to tell if there are breaking changes.

Can you please run coordinator and share the content of /metrics A) before the changes and B) now after these changes; ?

[cla-assistant]

Thank you for your submission! We really appreciate it. Like many open source projects, we ask that you all sign our Contributor License Agreement before we can accept your contribution.
0 out of 2 committers have signed the CLA.

❌ jonesho
❌ bradbown
_{You have signed the CLA already but the status is still pending? Let us recheck it.}

[jonesho]

@jonesho I still see a lot of diff changes in the JSON-RPC area, It's hard by looking at the code to tell if there are breaking changes.

Can you please run coordinator and share the content of /metrics A) before the changes and B) now after these changes; ?

I also attached the "before" and "after" metrics from transaction-exclusion-api as it would create the jsonrpc metrics (those won't be created from coordinator) when handling the json-rpc requests.

Coordinator metrics before the changes:
coordinator_metrics_b4.txt

Coordinator metrics after the changes:
coordinator_metrics_after.txt

Transaction-exclusion-api metrics before the changes:
tx_exclusion_api_metrics_b4.txt

Transaction-exclusion-api metrics after the changes:
tx_exclusion_api_metrics_after.txt

[jpnovais]

The time sample was taking the time here right at method beginning. Now it's move elsewhere. That will influence time measurements, no?

If read the code correctly, for instance now the time doing decodeMessage(requestJsonStr)