Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/Global Constraint Boundary Cancellation Explainer #335

Merged
merged 4 commits into from
Jan 6, 2025

Conversation

arijitdutta67
Copy link
Contributor

@arijitdutta67 arijitdutta67 commented Nov 25, 2024

This PR adds some explanatory comments on the boundary cancellation of the global constraints and fixes a small typo in an error message.

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@arijitdutta67 arijitdutta67 marked this pull request as ready for review November 25, 2024 12:51
@codecov-commenter
Copy link

codecov-commenter commented Nov 25, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.47%. Comparing base (3805acb) to head (aaef087).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #335      +/-   ##
============================================
+ Coverage     68.22%   70.47%   +2.25%     
+ Complexity     1128     1063      -65     
============================================
  Files           319      303      -16     
  Lines         12795    12171     -624     
  Branches       1277     1163     -114     
============================================
- Hits           8729     8578     -151     
+ Misses         3540     3109     -431     
+ Partials        526      484      -42     
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 68.15% <ø> (+2.31%) ⬆️ Carriedforward from 1143b60

*This pull request uses carry forward flags. Click here to find out more.

see 58 files with indirect coverage changes

@arijitdutta67 arijitdutta67 self-assigned this Nov 25, 2024
@arijitdutta67 arijitdutta67 added the Prover Tag to use for all work impacting the prover label Nov 29, 2024
@AlexandreBelling AlexandreBelling merged commit 9dc4304 into main Jan 6, 2025
25 checks passed
@AlexandreBelling AlexandreBelling deleted the arijit/global-constraint-fix branch January 6, 2025 08:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants