Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover/full recursion #350

Merged
merged 29 commits into from
Jan 6, 2025
Merged

Prover/full recursion #350

merged 29 commits into from
Jan 6, 2025

Conversation

AlexandreBelling
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling added the Prover Tag to use for all work impacting the prover label Nov 28, 2024
@AlexandreBelling AlexandreBelling self-assigned this Nov 28, 2024
arijitdutta67
arijitdutta67 previously approved these changes Dec 2, 2024
Soleimani193
Soleimani193 previously approved these changes Dec 2, 2024
@codecov-commenter
Copy link

codecov-commenter commented Dec 3, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 70.38%. Comparing base (4a7b76c) to head (a7dc2f2).
Report is 4 commits behind head on main.

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #350      +/-   ##
============================================
+ Coverage     68.22%   70.38%   +2.16%     
+ Complexity     1128     1061      -67     
============================================
  Files           319      305      -14     
  Lines         12795    12201     -594     
  Branches       1277     1166     -111     
============================================
- Hits           8729     8588     -141     
+ Misses         3540     3141     -399     
+ Partials        526      472      -54     
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (ø)
kotlin 68.06% <ø> (+2.21%) ⬆️ Carriedforward from ca0efc0

*This pull request uses carry forward flags. Click here to find out more.

see 50 files with indirect coverage changes

@srinathln7 srinathln7 self-requested a review January 6, 2025 08:50
@AlexandreBelling AlexandreBelling merged commit 3b875fd into main Jan 6, 2025
25 checks passed
@AlexandreBelling AlexandreBelling deleted the prover/full-recursion branch January 6, 2025 08:52
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants