Skip to content

[Fix] typo in variable name assignement to assignment #416

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Closed
wants to merge 30 commits into from
Closed
Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
30 commits
Select commit Hold shift + click to select a range
812a4f8
typo
huperts Dec 10, 2024
d79622f
typo
huperts Dec 10, 2024
7cf6e91
typo
huperts Dec 10, 2024
b735b32
typo
huperts Dec 10, 2024
8861e17
typo
huperts Dec 10, 2024
ac0b151
Merge branch 'main' into Linea-mono
huperts Dec 11, 2024
89c72c5
Merge branch 'main' into Linea-mono
huperts Dec 11, 2024
d05ff88
Merge branch 'main' into Linea-mono
huperts Dec 12, 2024
f87959f
Merge branch 'main' into Linea-mono
huperts Dec 13, 2024
a10c9d7
Merge branch 'main' into Linea-mono
huperts Dec 16, 2024
c1191c7
Merge branch 'main' into Linea-mono
huperts Dec 17, 2024
32d318f
Merge branch 'main' into Linea-mono
huperts Dec 17, 2024
16deaa9
Merge branch 'main' into Linea-mono
huperts Dec 20, 2024
379a693
Merge branch 'main' into Linea-mono
huperts Dec 26, 2024
502f504
Merge branch 'main' into Linea-mono
huperts Jan 7, 2025
0deb318
Merge branch 'main' into Linea-mono
huperts Jan 7, 2025
3dfcbf8
Merge branch 'main' into Linea-mono
huperts Jan 10, 2025
c01b34f
Merge branch 'main' into Linea-mono
huperts Jan 16, 2025
cfae265
Merge branch 'main' into Linea-mono
huperts Jan 18, 2025
7cb0694
Merge branch 'main' into Linea-mono
huperts Jan 20, 2025
0d89654
Merge branch 'main' into Linea-mono
huperts Jan 20, 2025
3d3e1bd
Merge branch 'main' into Linea-mono
huperts Jan 21, 2025
c1652c5
Merge branch 'main' into Linea-mono
huperts Jan 22, 2025
d13c675
Merge branch 'main' into Linea-mono
huperts Jan 23, 2025
5401f60
Merge branch 'main' into Linea-mono
huperts Jan 24, 2025
2d72103
Merge branch 'main' into Linea-mono
huperts Jan 28, 2025
cb79583
Merge branch 'main' into Linea-mono
huperts Jan 29, 2025
6841861
Merge branch 'main' into Linea-mono
huperts Jan 30, 2025
eb06e18
Merge branch 'main' into Linea-mono
huperts Feb 2, 2025
a373b5c
Merge branch 'main' into Linea-mono
huperts Feb 5, 2025
File filter

Filter by extension

Filter by extension

Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 1 addition & 1 deletion prover/maths/common/smartvectors/smartvectors.go
Original file line number Diff line number Diff line change
Expand Up @@ -79,7 +79,7 @@ func PseudoRand(rng *rand.Rand, n int) SmartVector {
return NewRegular(vector.PseudoRand(rng, n))
}

// ForTest returns a witness from a explicit litteral assignement
// ForTest returns a witness from a explicit litteral assignment
func ForTest(xs ...int) SmartVector {
return NewRegular(vector.ForTest(xs...))
}
Expand Down
2 changes: 1 addition & 1 deletion prover/protocol/compiler/splitter/splitter.go
Original file line number Diff line number Diff line change
Expand Up @@ -521,7 +521,7 @@ func (ctx splitterCtx) compileLocalOpening(comp *wizard.CompiledIOP, q query.Loc
run.AssignLocalPoint(newQName, params.Y)
})

// The verifier ensures that the old and new queries have the same assignement
// The verifier ensures that the old and new queries have the same assignment
comp.InsertVerifier(round, func(run *wizard.VerifierRuntime) error {
oldParams := run.GetLocalPointEvalParams(q.ID)
newParams := run.GetLocalPointEvalParams(newQName)
Expand Down
4 changes: 2 additions & 2 deletions prover/protocol/compiler/splitter/sticker/sticker.go
Original file line number Diff line number Diff line change
Expand Up @@ -241,10 +241,10 @@ func (ctx *stickContext) createMapToNew() {
for j := range values {
values[i] = smartvectors.IntoRegVec(ctx.comp.Precomputed.MustGet(group[j].GetColID()))
}
assignement := vector.Interleave(values...)
assignment := vector.Interleave(values...)
ctx.comp.InsertPrecomputed(
groupedName(group),
smartvectors.NewRegular(assignement),
smartvectors.NewRegular(assignment),
)
}

Expand Down
4 changes: 2 additions & 2 deletions prover/protocol/compiler/stitch_split/stitcher/stitcher.go
Original file line number Diff line number Diff line change
Expand Up @@ -154,11 +154,11 @@ func (ctx *stitchingContext) ScanStitchCommit() {
for i := range witnesses {
witnesses[i] = subColumns[i].GetColAssignment(run)
}
assignement := smartvectors.
assignment := smartvectors.
AllocateRegular(maxSizeGroup * witnesses[0].Len()).(*smartvectors.Regular)
for i := range subColumns {
for j := 0; j < witnesses[0].Len(); j++ {
(*assignement)[i+j*maxSizeGroup] = witnesses[i].Get(j)
(*assignment)[i+j*maxSizeGroup] = witnesses[i].Get(j)
}
}
run.AssignColumn(idBigCol, assignement)
Expand Down
2 changes: 1 addition & 1 deletion prover/protocol/dedicated/byte32cmp/multi_limb_cmp.go
Original file line number Diff line number Diff line change
Expand Up @@ -48,7 +48,7 @@ type multiLimbCmp struct {

// CmpMultiLimbs returns three columns: isGreater, isEqual and isLower which
// are mutually-exclusive pre-constrainted binary columns and a
// [wizard.ProverAction] computing their assignement. The returned columns
// [wizard.ProverAction] computing their assignment. The returned columns
// indicates whether the words represented by `a` are greater, equal or
// smaller compared to `b`. It can be used to perform comparison between large
// numbers.
Expand Down