Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: connect the codehash and the statesummary module #463

Merged
merged 16 commits into from
Jan 16, 2025

Conversation

AlexandreBelling
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@Anon-im
Copy link

Anon-im commented Dec 22, 2024

Thats cool

Copy link

cla-assistant bot commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

@AlexandreBelling AlexandreBelling requested a review from a team as a code owner January 13, 2025 09:24
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 1 line in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (5e7e7e1) to head (81930ab).
Report is 3 commits behind head on main.

Files with missing lines Patch % Lines
...acts/verifiers/PlonkVerifierForDataAggregation.sol 0.00% 1 Missing ⚠️
Additional details and impacted files
@@            Coverage Diff            @@
##               main     #463   +/-   ##
=========================================
  Coverage     68.18%   68.18%           
  Complexity     1129     1129           
=========================================
  Files           320      320           
  Lines         12855    12855           
  Branches       1292     1292           
=========================================
  Hits           8765     8765           
  Misses         3558     3558           
  Partials        532      532           
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <0.00%> (ø)
kotlin 65.71% <ø> (ø) Carriedforward from 5e7e7e1

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...acts/verifiers/PlonkVerifierForDataAggregation.sol 0.00% <0.00%> (ø)

arijitdutta67
arijitdutta67 previously approved these changes Jan 16, 2025
Soleimani193
Soleimani193 previously approved these changes Jan 16, 2025
gusiri
gusiri previously approved these changes Jan 16, 2025
Soleimani193
Soleimani193 previously approved these changes Jan 16, 2025
@AlexandreBelling AlexandreBelling dismissed stale reviews from Soleimani193 and gusiri via f3413c9 January 16, 2025 16:16
gusiri
gusiri previously approved these changes Jan 16, 2025
@AlexandreBelling AlexandreBelling merged commit aeb8685 into main Jan 16, 2025
24 checks passed
@AlexandreBelling AlexandreBelling deleted the feat/mimc-connect-codehash-2 branch January 16, 2025 21:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

6 participants