Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

added the compiler for logderivativesum #496

Merged

Conversation

Soleimani193
Copy link
Contributor

@Soleimani193 Soleimani193 commented Jan 6, 2025

This PR implements the compilation of a LogDerivativeSum query. This includes imposing the constraints over the Z column;

  • Z_j[0] = Num[0]/Den[0]
  • Z_j[i] = Z_j[i-1]+Num[i]/Den[i]
  • LocalOpening over each Z_j to find Z_j[last-row]
  • \Sum_j Z_j[last-row] = claimedSum

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@codecov-commenter
Copy link

codecov-commenter commented Jan 6, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Please upload report for BASE (prover/limitless-top-level@c05490e). Learn more about missing BASE report.

Additional details and impacted files
@@                      Coverage Diff                      @@
##             prover/limitless-top-level     #496   +/-   ##
=============================================================
  Coverage                              ?   70.17%           
  Complexity                            ?     1070           
=============================================================
  Files                                 ?      306           
  Lines                                 ?    12337           
  Branches                              ?     1179           
=============================================================
  Hits                                  ?     8658           
  Misses                                ?     3200           
  Partials                              ?      479           
Flag Coverage Δ *Carryforward flag
hardhat 98.70% <ø> (?)
kotlin 67.86% <ø> (?) Carriedforward from c62258c

*This pull request uses carry forward flags. Click here to find out more.

@Soleimani193 Soleimani193 marked this pull request as ready for review January 7, 2025 09:40
Copy link

cla-assistant bot commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

@Soleimani193 Soleimani193 merged commit 8ca8f0d into prover/limitless-top-level Jan 7, 2025
4 of 5 checks passed
@Soleimani193 Soleimani193 deleted the prover/logderivativesum-compilation branch January 7, 2025 11:14
@Soleimani193 Soleimani193 requested a deployment to docker-build-and-e2e January 7, 2025 11:15 — with GitHub Actions Waiting
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants