Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] - Check for forge install on Solidity docgen husky hook #501

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

kyzooghost
Copy link
Contributor

This PR implements issue(s) #500

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from a team as a code owner January 7, 2025 10:58
Copy link

cla-assistant bot commented Jan 7, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 7, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.22%. Comparing base (a5dffa3) to head (e0d639d).

Additional details and impacted files
@@             Coverage Diff              @@
##               main     #501      +/-   ##
============================================
+ Coverage     68.18%   68.22%   +0.04%     
+ Complexity     1129     1128       -1     
============================================
  Files           320      320              
  Lines         12855    12844      -11     
  Branches       1292     1291       -1     
============================================
- Hits           8765     8763       -2     
+ Misses         3558     3550       -8     
+ Partials        532      531       -1     
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (ø)
kotlin 65.76% <ø> (+0.04%) ⬆️ Carriedforward from 1d1d8fa

*This pull request uses carry forward flags. Click here to find out more.

see 4 files with indirect coverage changes

@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 9, 2025 09:23 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit 5e7e7e1 into main Jan 9, 2025
23 checks passed
@kyzooghost kyzooghost deleted the fix/solidity-docgen-husky-hook branch January 9, 2025 11:07
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants