Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Prover: new beta-v1 contract #504

Merged
merged 3 commits into from
Jan 8, 2025
Merged

Prover: new beta-v1 contract #504

merged 3 commits into from
Jan 8, 2025

Conversation

AlexandreBelling
Copy link
Contributor

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@AlexandreBelling AlexandreBelling added the Prover Tag to use for all work impacting the prover label Jan 7, 2025
@AlexandreBelling AlexandreBelling self-assigned this Jan 7, 2025
@AlexandreBelling AlexandreBelling requested a review from a team as a code owner January 7, 2025 20:37
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 0% with 2 lines in your changes missing coverage. Please review.

Project coverage is 68.20%. Comparing base (574e0ef) to head (ce7bc0b).

Files with missing lines Patch % Lines
...s/contracts/verifiers/PlonkVerifierSepoliaFull.sol 0.00% 2 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #504      +/-   ##
============================================
- Coverage     68.21%   68.20%   -0.02%     
  Complexity     1128     1128              
============================================
  Files           319      320       +1     
  Lines         12846    12848       +2     
  Branches       1291     1291              
============================================
  Hits           8763     8763              
- Misses         3552     3554       +2     
  Partials        531      531              
Flag Coverage Δ *Carryforward flag
hardhat 98.54% <0.00%> (-0.21%) ⬇️
kotlin 65.75% <ø> (ø) Carriedforward from 574e0ef

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...s/contracts/verifiers/PlonkVerifierSepoliaFull.sol 0.00% <0.00%> (ø)

@AlexandreBelling AlexandreBelling merged commit 2fb12b9 into main Jan 8, 2025
26 checks passed
@AlexandreBelling AlexandreBelling deleted the prover-beta-v1 branch January 8, 2025 10:10
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants