Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

jvm: fix resource loading on compressor/decompressor #505

Merged
merged 1 commit into from
Jan 8, 2025

Conversation

jpnovais
Copy link
Collaborator

@jpnovais jpnovais commented Jan 8, 2025

This PR implements issue(s) #

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

Copy link

cla-assistant bot commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

@jpnovais jpnovais temporarily deployed to docker-build-and-e2e January 8, 2025 09:53 — with GitHub Actions Inactive
@jpnovais jpnovais requested a review from a team January 8, 2025 09:53
@codecov-commenter
Copy link

Codecov Report

Attention: Patch coverage is 36.36364% with 7 lines in your changes missing coverage. Please review.

Project coverage is 68.18%. Comparing base (574e0ef) to head (ad24eb5).
Report is 1 commits behind head on main.

Files with missing lines Patch % Lines
...t/consensys/linea/blob/GoNativeBlobDecompressor.kt 0.00% 7 Missing ⚠️
Additional details and impacted files
@@             Coverage Diff              @@
##               main     #505      +/-   ##
============================================
- Coverage     68.21%   68.18%   -0.03%     
- Complexity     1128     1129       +1     
============================================
  Files           319      319              
  Lines         12846    12853       +7     
  Branches       1291     1292       +1     
============================================
+ Hits           8763     8764       +1     
- Misses         3552     3558       +6     
  Partials        531      531              
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (ø) Carriedforward from 574e0ef
kotlin 65.72% <36.36%> (-0.04%) ⬇️

*This pull request uses carry forward flags. Click here to find out more.

Files with missing lines Coverage Δ
...n/src/main/kotlin/build/linea/jvm/ResourcesUtil.kt 83.33% <100.00%> (+3.33%) ⬆️
...net/consensys/linea/blob/GoNativeBlobCompressor.kt 87.50% <100.00%> (ø)
...t/consensys/linea/blob/GoNativeBlobDecompressor.kt 0.00% <0.00%> (ø)

... and 2 files with indirect coverage changes

@jpnovais jpnovais merged commit 03b7667 into main Jan 8, 2025
24 checks passed
@jpnovais jpnovais deleted the jvm-fix-resource-loading branch January 8, 2025 10:29
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants