Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

[Fix] Remove dead code for finalized-tag-updater-github-release.yml automatic trigger #506

Merged
merged 2 commits into from
Jan 9, 2025

Conversation

kyzooghost
Copy link
Contributor

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@kyzooghost kyzooghost requested a review from jonesho January 8, 2025 11:44
Copy link

cla-assistant bot commented Jan 8, 2025

CLA assistant check
All committers have signed the CLA.

@codecov-commenter
Copy link

codecov-commenter commented Jan 8, 2025

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.16%. Comparing base (03b7667) to head (b1162d3).

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #506   +/-   ##
=========================================
  Coverage     68.16%   68.16%           
  Complexity     1129     1129           
=========================================
  Files           320      320           
  Lines         12855    12855           
  Branches       1292     1292           
=========================================
  Hits           8763     8763           
  Misses         3560     3560           
  Partials        532      532           
Flag Coverage Δ *Carryforward flag
hardhat 98.54% <ø> (ø) Carriedforward from 1bdc106
kotlin 65.71% <ø> (ø)

*This pull request uses carry forward flags. Click here to find out more.

@jonesho
Copy link
Contributor

jonesho commented Jan 8, 2025

@kyzooghost I think you can even remove the whole filter change file list here

@kyzooghost kyzooghost temporarily deployed to docker-build-and-e2e January 8, 2025 12:22 — with GitHub Actions Inactive
@kyzooghost kyzooghost merged commit 94f461a into main Jan 9, 2025
27 checks passed
@kyzooghost kyzooghost deleted the fix/remove-dead-workflow-trigger branch January 9, 2025 06:55
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants