Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore: update gnark dependency #580

Open
wants to merge 1 commit into
base: main
Choose a base branch
from
Open

chore: update gnark dependency #580

wants to merge 1 commit into from

Conversation

ivokub
Copy link
Contributor

@ivokub ivokub commented Jan 21, 2025

Update gnark dependency to include pairing check optimizations (implicit G2 membership check inside Miller loop subroutine). Reduces the Miller loop circuit size by 10-15% depending on the number of input instances configured.

I have ran the full testsuite for ecpair glue

Checklist

  • I wrote new tests for my new core changes.
  • I have successfully ran tests, style checker and build against my new changes locally.
  • I have informed the team of any breaking changes if there are any.

@ivokub ivokub added the Prover Tag to use for all work impacting the prover label Jan 21, 2025
@ivokub ivokub requested a review from gusiri January 21, 2025 10:02
@ivokub ivokub self-assigned this Jan 21, 2025
@ivokub ivokub requested a deployment to docker-build-and-e2e January 21, 2025 10:06 — with GitHub Actions Waiting
@codecov-commenter
Copy link

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 68.89%. Comparing base (d01ef99) to head (38c57ff).
Report is 3 commits behind head on main.

Additional details and impacted files
@@            Coverage Diff            @@
##               main     #580   +/-   ##
=========================================
  Coverage     68.89%   68.89%           
  Complexity     1186     1186           
=========================================
  Files           327      327           
  Lines         13128    13128           
  Branches       1317     1317           
=========================================
  Hits           9044     9044           
  Misses         3535     3535           
  Partials        549      549           
Flag Coverage Δ *Carryforward flag
hardhat 98.74% <ø> (ø)
kotlin 66.53% <ø> (ø) Carriedforward from d01ef99

*This pull request uses carry forward flags. Click here to find out more.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Prover Tag to use for all work impacting the prover
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants