Prover/Convert projection protocol to a query #585
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
arijitdutta67
changed the title
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prover/limitless-top-level #585 +/- ##
================================================================
- Coverage 68.49% 68.46% -0.04%
+ Complexity 1130 1129 -1
================================================================
Files 321 321
Lines 12842 12842
Branches 1287 1287
================================================================
- Hits 8796 8792 -4
- Misses 3506 3507 +1
- Partials 540 543 +3
|
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
arijitdutta67
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
arijitdutta67
temporarily deployed
to
docker-build-and-e2e
GitHub Actions
Inactive
arijitdutta67
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
jvm-libs/blob-compressor/src/test/resources/net/consensys/linea/nativecompressor/rlp_blocks.bin
Outdated
Show resolved
Hide resolved
| @@ -273,7 +273,7 @@ func (a *Alignment) csIsActive(comp *wizard.CompiledIOP) { | |||
| // csProjection ensures the data in the [Alignment.Data] column is the same as | |||
| // the data provided by the [Alignment.CircuitInput]. | |||
| func (a *Alignment) csProjection(comp *wizard.CompiledIOP) { | |||
| projection.InsertProjection(comp, ifaces.QueryIDf("%v_PROJECTION", a.Name), []ifaces.Column{a.DataToCircuit}, []ifaces.Column{a.CircuitInput}, a.DataToCircuitMask, a.ActualCircuitInputMask) | |||
| projection.RegisterProjection(comp, ifaces.QueryIDf("%v_PROJECTION", a.Name), []ifaces.Column{a.DataToCircuit}, []ifaces.Column{a.CircuitInput}, a.DataToCircuitMask, a.ActualCircuitInputMask) | |||
There was a problem hiding this comment.
Shouldn't that be a method of 'comp' now?
| "github.com/consensys/linea-monorepo/prover/protocol/wizardutils" | ||
| ) | ||
|
|
||
| func RegisterProjection( |
There was a problem hiding this comment.
Iiuc, this function does not do really anything on top of comp.InsertProverAction.
It would simplify the code if we removed it.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR converts the projection protocol to a query of the compiled IOP. This is a prerequisite for horizontal and vertical splitting for the limitless prover.
Checklist