shared randomness for limitless prover #587
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Soleimani193
changed the title
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## prover/limitless-top-level #587 +/- ##
=============================================================
Coverage 68.49% 68.49%
Complexity 1130 1130
=============================================================
Files 321 321
Lines 12842 12842
Branches 1287 1287
=============================================================
Hits 8796 8796
Misses 3506 3506
Partials 540 540
*This pull request uses carry forward flags. Click here to find out more. |
Soleimani193
force-pushed
the
prover/shared-randomness-for-limitless-prover
branch
from
5d2773c to
df004ef
Compare
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
prover/protocol/column/column.go
Outdated
| @@ -119,7 +120,11 @@ func EvalExprColumn(run ifaces.Runtime, board symbolic.ExpressionBoard) smartvec | |||
| case ifaces.Column: | |||
| inputs[i] = m.GetColAssignment(run) | |||
| case coin.Info: | |||
| v := run.GetRandomCoinField(m.Name) | |||
| if m.Type == coin.FromSeed { | |||
| v = run.GetRandomCoinFromSeed(m.Name) | |||
There was a problem hiding this comment.
It would be simpler if you modified GetRandomCoinField to be able to do that. That way you would not change this everytime we sample a coin.
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Soleimani193
had a problem deploying
to
docker-build-and-e2e
GitHub Actions
Error
Soleimani193
requested a deployment
to
docker-build-and-e2e
GitHub Actions
Waiting
AlexandreBelling
approved these changes
Jan 24, 2025
Soleimani193
merged commit 07ae16a
into
prover/limitless-top-level
14 of 15 checks passed
Soleimani193
deleted the
prover/shared-randomness-for-limitless-prover
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements the generation of shared randomness for the distributed prover.
Checklist