Prover: fix the txnrlp duplicated txnrlp bug #80
Merged
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR implements a fix for an outstanding integration issue between the prover and txnrlp. The issue is that the prover infers a transaction signature via a mapping between tx-hash and tx-signature but it is possible that two transactions have the same transaction hash (as in the hash for signing). In that case, the current approach will not work. This PR addresses the issue by mapping the signature by tx-id.
The tx-hash is still used to sanity-check that the signature that is infered relates to the expected transaction. Thus, helping in the debugging process if any bugs stands out here.