Mega precompile testing PR: SHA2-256, RIPEMD-160, IDENTITY, MODEXP, ECADD, ECMUL, ECRECOVER
#1778
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
They now - produce return data via some precompile and play around with it - wipe said return data (and play around with it) - produce return data via some other precompile and play around with it
|
These means are: - as init code of a MESSAGE_CALL transaction - as init code of a CONTRACT_DEPLOYMENT transaction - as a message call emanating from ROOT - as the init code of a CREATE launched from the ROOT - as the deployed code of a deployment done by ROOT
OlivierBBB
changed the title
SHA2-256, RIPEMD-160 and IDENTITYSHA2-256, RIPEMD-160, IDENTITY, MODEXP, ECADD, ECMUL, ECRECOVER
There was a problem hiding this comment.
rebase issue I guesss ?
letypequividelespoubelles
approved these changes
Feb 19, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
The purpose of this issue is to test the "happy path" of precompiles in the following scenarios:
MESSAGE_CALL_TRANSACTION: the ROOT contract calls the precompileCONTRACT_DEPLOYMENT_TRANSACTION: the init code running in the ROOT calls the precompileMESSAGE_CALL_FROM_ROOT: the ROOT does a CALL to some SMC; this SMC performs the requisite calls to the precompile;DURING_DEPLOYMENT: the ROOT deploys a contract (via CREATE); the init code of said deployment performs the requisite CALLs to the desired precompile;AFTER_DEPLOYMENT: the ROOT deploys a contract (via CREATE); the thus deployed SMC is then called by the ROOT; the SMC then performs the desired call to the precompile.We achieve this by using the 5 code execution methods from the
CodeExecutionMethodsclass.We cover the following precompiles:
SHA2-256RIPEMD-160IDENTITYMODEXPECADDECMULECRECOVER