Prover tests for empty blocks #2443

OlivierBBB · 2025-10-22T13:59:51Z

Note

Adds parameterized empty-block test scenarios and enables Besu-based execution/tracing with null-transaction placeholders, plus a minor Osaka import fix.

Tests:
- Parameterize EmptyBlockTests to run with/without Besu across multiple empty/non-empty sequences (EENENE, NEEN, NEEE, ENNE, EEEE, EEEN, E).
- Factor shared setup into class fields and builderFromBlockTypeList(...); conditionally validate hub/logs only when not using Besu.
Testing infrastructure:
- MultiBlockExecutionEnvironment gains runWithBesuNode; when enabled, flattens blocks into a per-block stream including null for empty blocks and executes via BesuExecutionTools.
- BesuExecutionTools accepts null transactions to represent empty blocks, requires at least one entry, computes trace start/end when all are empty, and aligns proof requests accordingly.
Minor:
- Update Osaka gas-cap import to TraceOsaka.EIP_7825_TRANSACTION_GAS_LIMIT_CAP in OsakaUserTransaction.

^{Written by Cursor Bugbot for commit dfadcae. This will update automatically on new commits. Configure here.}

cursor · 2025-10-23T07:58:42Z

Bug: Null Transaction Handling Bug

When oneTxPerBlock is false, the executeTest method attempts to send all transactions without checking if they are null. This leads to a NullPointerException when calling .encoded() on a null transaction, a check that is present in the oneTxPerBlock true path.

cursor · 2025-10-23T07:58:42Z

Bug: Transaction List Nulls Cause Block Number Errors

The firstBlockNumber calculation is off when oneTxPerBlock is true and the transactions list includes nulls. The current logic subtracts numberOfLeadingEmptyBlocks from an already adjusted firstBlockNumber, which can lead to invalid block numbers (like zero or negative) and an incorrect tracing range.

cursor · 2025-10-23T07:58:43Z

Bug: Block Number Calculation Incorrect for Non-Standard Genesis Blocks

When blockNumbers.isEmpty() is true (all transactions are null), firstBlockNumber is set to 1 and finalBlockNumber is set to transactions.size(). This assumes the starting block number is 1, but blocks may start at a different number. The calculation should use the genesis block configuration or track the actual block numbers created, not hardcode 1.

cursor · 2025-10-23T08:33:46Z

Bug: Null Transaction Handling Mismatch

The else branch, which sends all transactions in a single block, doesn't filter out null transactions from the transactions list. This causes a NullPointerException when txs.next() returns null and encoded() is called, unlike the if branch which correctly handles these null entries.

cursor · 2025-10-23T08:33:47Z

Bug: Test Initialization Order Causes Null References

Instance fields (senderKeyPair, receivingAccount, storingNumber, logging, storing, reading) are initialized with references to chainConfig, but chainConfig is only initialized by the test framework after instance field initialization. This will cause these fields to use a null or uninitialized chainConfig, leading to NullPointerException or incorrect bytecode compilation. These fields should either be initialized lazily in a @beforeeach method or moved into the test methods themselves.

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java

amkCha · 2025-11-06T14:13:09Z

Thanks for fixing the daily ref tests !!

cursor · 2025-11-06T15:27:56Z

testing/src/main/java/net/consensys/linea/testing/BesuExecutionTools.java

+            String txHash =
+                besuNode.execute(ethTransactions.sendRawTransaction(tx.encoded().toHexString()));
+            txHashes.add(txHash);
+          }


Bug: NullPointer on Null Transactions in Else Branch

NullPointerException when oneTxPerBlock is false and transactions list contains null values. The else branch (lines 216-223) attempts to call .encoded() on txs.next() without checking if the transaction is null first. When a null transaction is encountered (representing an empty block), this will throw a NullPointerException. The if branch (lines 207-214) correctly handles null transactions with a null check, but the else branch is missing this protection.

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java

cursor · 2025-11-10T14:48:57Z

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java

+              null);
+      besuExecTools.executeTest();
+      return;
+    }


Bug: Early Exit Prevents Tracer Initialization

When runWithBesuNode is true, the run() method returns early without initializing the tracer field, leaving it null. Tests that call getHub() after running with Besu node will encounter a NullPointerException since getHub() returns tracer.getHub() and tracer is null.

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java

various configurations of empty / nonempty blocks, in particular E EEEE EEEN NEEN NEEE ENNE EENENE where E = empty block, N = nonempty block

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java

…erized with and without besu nodes

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java

+        for (State.HubTransactionState state : hub.getState().getAll()) {
+          for (TraceSection section : state.traceSections().trace()) {
+            if (section instanceof LogSection) {
+              nbOfLog += 1;


The best way to fix this problem is to widen the type of nbOfLog from short to int. This prevents any implicit narrowing conversion when performing compound assignment operations like nbOfLog += 1;. The code's logic and surrounding assumptions are not altered: the only change is the variable's type. You should update the declaration at line 180 from short to int. No additional imports or refactoring are required, and no other code changes are necessary.

cursor · 2025-11-20T15:52:42Z

testing/src/main/java/net/consensys/linea/testing/BesuExecutionTools.java

-        long startBlockNumber = Collections.min(blockNumbers);
-        long endBlockNumber = Collections.max(blockNumbers);
-        TraceFile traceFile = traceAndCheckTracer(startBlockNumber, endBlockNumber, currentFork);
+        checkState(blockNumbers.isEmpty() == allTransactionsAreNull);


Bug: Assertion failure for mixed empty blocks

The assertion checkState(blockNumbers.isEmpty() == allTransactionsAreNull) fails when processing an empty block in a test suite containing a mix of empty and non-empty blocks. For an empty block, blockNumbers is empty (no receipts), but allTransactionsAreNull is false, causing an IllegalStateException.

testing/src/main/java/net/consensys/linea/testing/BesuExecutionTools.java

cursor · 2025-11-20T15:52:42Z

testing/src/main/java/net/consensys/linea/testing/BesuExecutionTools.java

-        long startBlockNumber = Collections.min(blockNumbers);
-        long endBlockNumber = Collections.max(blockNumbers);
-        TraceFile traceFile = traceAndCheckTracer(startBlockNumber, endBlockNumber, currentFork);
+        checkState(blockNumbers.isEmpty() == allTransactionsAreNull);


Bug: Invalid assertion for mixed empty blocks

The checkState condition enforces that empty blocks (empty blockNumbers) can only occur if every transaction in the test is null. This causes an IllegalStateException when running tests with a mix of empty and non-empty blocks, as processing a single empty block results in blockNumbers being empty while allTransactionsAreNull is false.

cursor · 2025-11-20T15:52:43Z

testing/src/main/java/net/consensys/linea/testing/BesuExecutionTools.java

+        long firstBlockNumber = blockNumbers.isEmpty() ? 1 : Collections.min(blockNumbers);
+        long finalBlockNumber =
+            blockNumbers.isEmpty() ? transactions.size() : Collections.max(blockNumbers);
+        TraceFile traceFile = traceAndCheckTracer(firstBlockNumber, finalBlockNumber, currentFork);


Bug: Trace generation requests non-existent blocks

When handling an empty block, finalBlockNumber defaults to the total number of transactions (transactions.size()). In sequential execution, this triggers a trace request for the entire planned block range before subsequent blocks have been mined, which will cause RPC errors by requesting blocks that do not yet exist.

cursor · 2025-11-23T14:51:52Z

testing/src/main/java/net/consensys/linea/testing/BesuExecutionTools.java

-        long startBlockNumber = Collections.min(blockNumbers);
-        long endBlockNumber = Collections.max(blockNumbers);
-        TraceFile traceFile = traceAndCheckTracer(startBlockNumber, endBlockNumber, currentFork);
+        checkState(blockNumbers.isEmpty() == allTransactionsAreNull);


Bug: Null transaction causes NullPointerException when oneTxPerBlock false

When oneTxPerBlock is false, the code calls txs.next().encoded() without checking if the transaction is null. Null transactions represent empty blocks in this implementation, so calling .encoded() on null will throw a NullPointerException. The null check added for the oneTxPerBlock == true case is missing here.

OlivierBBB requested review from amkCha and gauravahuja October 22, 2025 13:59

OlivierBBB self-assigned this Oct 22, 2025

OlivierBBB added testing unit tests labels Oct 22, 2025

gauravahuja approved these changes Oct 22, 2025

View reviewed changes

amkCha reviewed Oct 27, 2025

View reviewed changes

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java Outdated Show resolved Hide resolved

amkCha reviewed Oct 27, 2025

View reviewed changes

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java Outdated Show resolved Hide resolved

amkCha reviewed Oct 27, 2025

View reviewed changes

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java Outdated Show resolved Hide resolved

amkCha reviewed Oct 27, 2025

View reviewed changes

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java Show resolved Hide resolved

cursor bot reviewed Nov 6, 2025

View reviewed changes

cursor bot reviewed Nov 10, 2025

View reviewed changes

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java Outdated Show resolved Hide resolved

amkCha approved these changes Nov 10, 2025

View reviewed changes

cursor bot reviewed Nov 10, 2025

View reviewed changes

cursor bot reviewed Nov 20, 2025

View reviewed changes

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java Show resolved Hide resolved

arithmetization/src/test/java/net/consensys/linea/zktracer/EmptyBlockTests.java Outdated Show resolved Hide resolved

feat: new tests state manager integration

d540cc1

various configurations of empty / nonempty blocks, in particular E EEEE EEEN NEEN NEEE ENNE EENENE where E = empty block, N = nonempty block

cursor bot reviewed Nov 20, 2025

View reviewed changes

testing/src/main/java/net/consensys/linea/testing/MultiBlockExecutionEnvironment.java Show resolved Hide resolved

OlivierBBB added 7 commits November 20, 2025 12:50

xfeat: allow MultiBlock tests to run with Besu node

a79d814

feat: allow for empty blocks in BesuNodeTests

0d3f352

spotless

12636a4

feat: add runWithBesu field to MultiBlockExecutionEnvironement

fcfd721

spotless

0712a76

feat: configurable fork

6d3a3a7

spotless ... again

afa1aed

OlivierBBB added 3 commits November 20, 2025 12:51

feat: add runWithBesu field to MultiBlockExecutionEnvironement

fa955a7

feat: configurable fork

6a2413c

feat: allow MultiBlock tests to run with Besu node

5b879ed

amkCha force-pushed the prover-tests-for-empty-blocks branch from 419045b to 7a66335 Compare November 20, 2025 11:53

feat: add runWithBesu field to MultiBlockExecutionEnvironement

5342cec

amkCha force-pushed the prover-tests-for-empty-blocks branch from 7a66335 to 5342cec Compare November 20, 2025 12:00

amkCha added 2 commits November 20, 2025 16:38

feat: tests to fit empty and non empty cases + make empty test paramt…

37a3009

…erized with and without besu nodes

Merge branch 'arith-dev' into prover-tests-for-empty-blocks

84ae444

github-advanced-security bot found potential problems Nov 20, 2025

View reviewed changes

amkCha added 2 commits November 20, 2025 16:47

fix

0d9984f

fix

c5bc7af

amkCha enabled auto-merge (squash) November 20, 2025 15:48

cursor bot reviewed Nov 20, 2025

View reviewed changes

Merge branch 'arith-dev' into prover-tests-for-empty-blocks

dfadcae

cursor bot reviewed Nov 23, 2025

View reviewed changes

@@ -177,7 +177,7 @@
                   if (!runWithBesu) {
                     final State hub = env.getHub().state();
-                    short nbOfLog = 0;
+                    int nbOfLog = 0;
                     for (State.HubTransactionState state : hub.getState().getAll()) {
                       for (TraceSection section : state.traceSections().trace()) {
                         if (section instanceof LogSection) {

Prover tests for empty blocks #2443

Are you sure you want to change the base?

Prover tests for empty blocks #2443

Conversation

OlivierBBB commented Oct 22, 2025 • edited by cursor bot Loading Uh oh! There was an error while loading. Please reload this page.

Uh oh!

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Null Transaction Handling Bug

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Transaction List Nulls Cause Block Number Errors

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Block Number Calculation Incorrect for Non-Standard Genesis Blocks

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Null Transaction Handling Mismatch

Uh oh!

cursor bot commented Oct 23, 2025

Bug: Test Initialization Order Causes Null References

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Uh oh!

amkCha commented Nov 6, 2025

Uh oh!

cursor bot Nov 6, 2025

Choose a reason for hiding this comment

Bug: NullPointer on Null Transactions in Else Branch

Uh oh!

Uh oh!

cursor bot Nov 10, 2025

Choose a reason for hiding this comment

Bug: Early Exit Prevents Tracer Initialization

Uh oh!

Uh oh!

Uh oh!

Uh oh!

Check failure

Uh oh!

Copilot Autofix

cursor bot Nov 20, 2025

Choose a reason for hiding this comment

Bug: Assertion failure for mixed empty blocks

Uh oh!

Uh oh!

cursor bot Nov 20, 2025

Choose a reason for hiding this comment

Bug: Invalid assertion for mixed empty blocks

Uh oh!

cursor bot Nov 20, 2025

Choose a reason for hiding this comment

Bug: Trace generation requests non-existent blocks

Uh oh!

cursor bot Nov 23, 2025

Choose a reason for hiding this comment

Bug: Null transaction causes NullPointerException when oneTxPerBlock false

Uh oh!

Reviewers

Assignees

Labels

Projects

Milestone

Development

Uh oh!

4 participants

OlivierBBB commented Oct 22, 2025 •

edited by cursor bot

Loading