Implement blob_sidecar event
#7561
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lucassaldanha
approved these changes
Oct 1, 2023
There was a problem hiding this comment.
Do we need a test for only calling newBlobSidecarSubscribers.deliver() when the block is new?
There was a problem hiding this comment.
Not sure what you mean here. I added a test onNewBlobSidecar_shouldIgnoreDuplicates. Does it cover, in conjunction with onNewBlobSidecar_shouldIgnoreBlobsForAlreadyImportedBlocks, your doubts?
...c/main/java/tech/pegasys/teku/beaconrestapi/handlers/v1/events/EventSubscriptionManager.java
Outdated
Show resolved
Hide resolved
|
merging this 'cose it could be useful for devnet-9. Happy to update tests in a later PR if need. |
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Implements
blob_sidecarSSE event.Note that this diverges from block implementation: to capture locally produced blobs as well as the one arriving via gossip, I intercept blobs at
BlobSidecarPoolinstead ofBlobSidecarManagerPartially implements #7513
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog