Handle invalid Json bad request body in PostStateValidators

[courtneyeh]

#7670

Documentation

• I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

• I thought about adding a changelog entry, and added one if I deemed necessary.

[lucassaldanha]

Suggested change

	try {
	requestBody = request.getOptionalRequestBody();
	} catch (RuntimeException e) {
	final Throwable throwable = Throwables.getRootCause(e);
	if (throwable instanceof JsonParseException) {
	request.respondError(SC_BAD_REQUEST, throwable.getMessage());
	} else {
	throw e;
	}
	return;
	}
	try {
	requestBody = request.getOptionalRequestBody();
	} catch (JsonProcessingException e) {
	final Throwable throwable = Throwables.getRootCause(e);
	request.respondError(SC_BAD_REQUEST, throwable.getMessage());
	return;
	} catch (RuntimeException e) {
	throw e;
	}

[courtneyeh]

That would not work because the exception is a RuntimeException, but the root cause of the exception is a JsonProcessingException. So cannot just catch the JsonProcessingException as you have.

[lucassaldanha]

I'll take a look later. Maybe there is something we can do on the getOptionalRequeatBody.

But it can be done in a separate PR, no need to block this.

[lucassaldanha]

LGTM. Just a nit suggestion when handling the exceptions.