Add block_gossip SSE event #7941
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StefanBratanov
force-pushed
the
block_gossip_sse_event
branch
from
b6236df
to
cc95415
Compare
rolfyone
reviewed
Jan 31, 2024
Comment on lines
-126
to
-147
| @Option( | ||
| names = {"--beacon-events-block-notify-when-validated-enabled"}, | ||
| paramLabel = "<BOOLEAN>", | ||
| showDefaultValue = Visibility.ALWAYS, | ||
| description = | ||
| "Block notification events will be sent once the block has been validated, prior to attempting to import the block. The optimistic flag will be determined based on if chain head is optimistic.", | ||
| arity = "0..1", | ||
| fallbackValue = "true") | ||
| private Boolean beaconEventsBlockNotifyWhenValidated = | ||
| BeaconRestApiConfig.DEFAULT_BEACON_EVENTS_BLOCK_NOTIFY_WHEN_VALIDATED_ENABLED; | ||
|
|
||
| @Option( | ||
| names = {"--beacon-events-block-notify-when-imported-enabled"}, | ||
| paramLabel = "<BOOLEAN>", | ||
| showDefaultValue = Visibility.ALWAYS, | ||
| description = | ||
| "Block notification events will be sent once the block has been imported, at which point we can accurately set the optimistic flag.", | ||
| arity = "0..1", | ||
| fallbackValue = "true") | ||
| private Boolean beaconEventsBlockNotifyWhenImported = | ||
| BeaconRestApiConfig.DEFAULT_BEACON_EVENTS_BLOCK_NOTIFY_WHEN_IMPORTED_ENABLED; | ||
|
|
There was a problem hiding this comment.
Yup, forgot the changelog. Added now.
StefanBratanov
force-pushed
the
block_gossip_sse_event
branch
from
8624210
to
8dbff66
Compare
StefanBratanov
force-pushed
the
block_gossip_sse_event
branch
from
8dbff66
to
a3ca213
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
block_gossipevent when block is validated.ImportedBlockListenertoReceivedBlockListenerand addonValidatedmethod--beacon-events-block-notify-when-validated-enabledand--beacon-events-block-notify-when-imported-enabledsince now we have two SSE eventsTODO:
I still find
BlockImportNotificationsandReceivedBlockListenerbit redundant.Fixed Issue(s)
fixes #7513
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog