Skip EL part of graffiti when EL info not available #8175
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Isn't it better if the length requirements change if EL information is not available because less bytes are needed? |
|
Also I think better to use null and remove UNKNOWN in some improbable case where some EL sends us same as UNKNOWN 😁 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
PR Description
We are currently filling it with something like
NA0000, which is not beautiful, so we decided to skip it at all in this case.Also behavior was updated to push UNKNOWN version in channel when it's not known due to failure or whatever, but do it only once per client start. So we could have normal log line with expected graffiti on start when execution client is not supporting the new API and it will be not noisy if there are issues with EL.
PS: I don't try to put more CL info in graffiti when EL version is unknown to make it simpler.
Fixed Issue(s)
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog