Dump p2p on files instead of hex logs

infrastructure/logging/build.gradle

@@ -6,6 +6,8 @@ dependencies {
     implementation 'org.apache.logging.log4j:log4j-core'
     compileOnly 'com.github.oshi:oshi-core'
 
+    testImplementation testFixtures(project(':ethereum:spec'))
+    testImplementation testFixtures(project(':infrastructure:time'))
     testFixturesImplementation 'org.apache.logging.log4j:log4j-core'
     testImplementation 'com.github.oshi:oshi-core'
 }

infrastructure/logging/src/main/java/tech/pegasys/teku/infrastructure/logging/P2PDumpManager.java

@@ -0,0 +1,106 @@
+/*
+ * Copyright Consensys Software Inc., 2024
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+
+package tech.pegasys.teku.infrastructure.logging;
+
+import java.io.IOException;
+import java.nio.file.FileAlreadyExistsException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Optional;
+import org.apache.logging.log4j.LogManager;
+import org.apache.logging.log4j.Logger;
+import org.apache.tuweni.bytes.Bytes;
+import org.apache.tuweni.bytes.Bytes32;
+import tech.pegasys.teku.infrastructure.unsigned.UInt64;
+
+public class P2PDumpManager {
+  private static final Logger LOG = LogManager.getLogger();
+
+  private static final String GOSSIP_DECODING_ERROR_DIR = "gossip_decoding_error_messages";
+  private static final String GOSSIP_REJECTED_DIR = "rejected_gossip_messages";
+  private static final String INVALID_BLOCK_DIR = "invalid_blocks";
+
+  public static Optional<String> saveGossipMessageDecodingError(
+      final Path directory,
+      final String topic,
+      final String arrivalTimestamp,
+      final Bytes originalMessage) {
+    final String fileName = String.format("%s_%s.ssz", arrivalTimestamp, topic);
+    final String identifiers = String.format("Topic: %s", topic);
+    return saveBytesToFile(
+        directory,
+        "gossip message with decoding error",
+        GOSSIP_DECODING_ERROR_DIR,
+        fileName,
+        identifiers,
+        originalMessage);
+  }
+
+  public static Optional<String> saveGossipRejectedMessageToFile(
+      final Path directory,
+      final String topic,
+      final String arrivalTimestamp,
+      final Bytes decodedMessage) {
+    final String fileName = String.format("%s_%s.ssz", arrivalTimestamp, topic);
+    final String identifiers = String.format("Topic: %s", topic);
+    return saveBytesToFile(
+        directory,
+        "rejected gossip message",
+        GOSSIP_REJECTED_DIR,
+        fileName,
+        identifiers,
+        decodedMessage);
+  }
+
+  public static Optional<String> saveInvalidBlockToFile(
+      final Path directory, final UInt64 slot, final Bytes32 blockRoot, final Bytes blockSsz) {
+    final String fileName =
+        String.format("slot%s_root%s.ssz", slot, blockRoot.toUnprefixedHexString());
+    final String identifiers = String.format("Slot: %s, Block Root: %s", slot, blockRoot);
+    return saveBytesToFile(
+        directory, "invalid block", INVALID_BLOCK_DIR, fileName, identifiers, blockSsz);
+  }
+
+  private static Optional<String> saveBytesToFile(
+      final Path baseDirectory,
+      final String object,
+      final String errorDirectory,
+      final String fileName,
+      final String identifiers,
+      final Bytes bytes) {
+    // Check directory exists
+    final Path directory = baseDirectory.resolve(errorDirectory);
+    if (directory.toFile().mkdir()) {
+      LOG.info(String.format("%s directory has been created to save %s.", errorDirectory, object));
+    }
+    final Path path = directory.resolve(fileName);
+
+    try {
+      // Create file and save ssz
+      if (!path.toFile().createNewFile()) {
+        final String errorMessage =
+            String.format("Unable to create new file to save %s. %s", object, identifiers);
+        throw new FileAlreadyExistsException(errorMessage);
+      }
+      final Path writtenPath = Files.write(path, bytes.toArray());
+      return Optional.of(writtenPath.toString());
+
+    } catch (IOException e) {
+      final String errorMessage =
+          String.format("Failed to save %s bytes to file. %s", object, identifiers);
+      LOG.error(errorMessage, e);
+      return Optional.empty();
+    }
+  }
+}

infrastructure/logging/src/test/java/tech/pegasys/teku/infrastructure/logging/P2PDumpManagerTest.java

@@ -0,0 +1,155 @@
+/*
+ * Copyright Consensys Software Inc., 2024
+ *
+ * Licensed under the Apache License, Version 2.0 (the "License"); you may not use this file except in compliance with
+ * the License. You may obtain a copy of the License at
+ *
+ * http://www.apache.org/licenses/LICENSE-2.0
+ *
+ * Unless required by applicable law or agreed to in writing, software distributed under the License is distributed on
+ * an "AS IS" BASIS, WITHOUT WARRANTIES OR CONDITIONS OF ANY KIND, either express or implied. See the License for the
+ * specific language governing permissions and limitations under the License.
+ */
+
+package tech.pegasys.teku.infrastructure.logging;
+
+import static org.assertj.core.api.Assertions.assertThat;
+import static org.junit.jupiter.api.Assertions.fail;
+
+import java.io.IOException;
+import java.nio.file.Files;
+import java.nio.file.Path;
+import java.util.Optional;
+import org.apache.tuweni.bytes.Bytes;
+import org.junit.jupiter.api.Test;
+import org.junit.jupiter.api.io.TempDir;
+import tech.pegasys.teku.infrastructure.time.StubTimeProvider;
+import tech.pegasys.teku.spec.TestSpecFactory;
+import tech.pegasys.teku.spec.datastructures.blocks.SignedBeaconBlock;
+import tech.pegasys.teku.spec.util.DataStructureUtil;
+
+class P2PDumpManagerTest {
+  final DataStructureUtil dataStructureUtil =
+      new DataStructureUtil(TestSpecFactory.createDefault());
+
+  private final StubTimeProvider timeProvider = StubTimeProvider.withTimeInSeconds(10_000);
+
+  @Test
+  void saveGossipMessageDecodingError_shouldSaveToFile(@TempDir Path tempDir) {
+    final Bytes messageBytes = dataStructureUtil.stateBuilderPhase0().build().sszSerialize();
+    final String arrivalTimestamp = timeProvider.getTimeInMillis().toString();
+    final Optional<String> file =
+        P2PDumpManager.saveGossipMessageDecodingError(
+            tempDir, "test_topic", arrivalTimestamp, messageBytes);
+    assertThat(file).isPresent();
+
+    final String fileName = String.format("%s_%s.ssz", arrivalTimestamp, "test_topic");
+    final Path expectedFile = tempDir.resolve("gossip_decoding_error_messages").resolve(fileName);
+    assertThat(file.get()).isEqualTo(expectedFile.toString());
+    checkBytesSavedToFile(expectedFile, messageBytes);
+  }
+
+  @Test
+  void saveGossipMessageDecodingError_failsToCreateFile(@TempDir Path tempDir) throws IOException {
+    final Bytes messageBytes = dataStructureUtil.stateBuilderPhase0().build().sszSerialize();
+    final String arrivalTimestamp = timeProvider.getTimeInMillis().toString();
+    final Path decodingErrorMessagesDir = tempDir.resolve("gossip_decoding_error_messages");
+
+    // Make invalid_blocks directory
+    assertThat(decodingErrorMessagesDir.toFile().mkdir()).isTrue();
+
+    // Make file with expected name
+    final String fileName = String.format("%s_%s.ssz", arrivalTimestamp, "test_topic");
+    assertThat(decodingErrorMessagesDir.resolve(fileName).toFile().createNewFile()).isTrue();
+
+    // Should not be able to create file when exists
+    final Optional<String> file =
+        P2PDumpManager.saveGossipMessageDecodingError(
+            tempDir, "test_topic", arrivalTimestamp, messageBytes);
+    assertThat(file).isEmpty();
+    checkBytesSavedToFile(decodingErrorMessagesDir.resolve(fileName), Bytes.EMPTY);
+  }
+
+  @Test
+  void saveGossipRejectedMessageToFile_shouldSaveToFile(@TempDir Path tempDir) {
+    final Bytes messageBytes = dataStructureUtil.stateBuilderPhase0().build().sszSerialize();
+    final String arrivalTimestamp = timeProvider.getTimeInMillis().toString();
+    final Optional<String> file =
+        P2PDumpManager.saveGossipRejectedMessageToFile(
+            tempDir, "test_topic", arrivalTimestamp, messageBytes);
+    assertThat(file).isPresent();
+
+    final String fileName = String.format("%s_%s.ssz", arrivalTimestamp, "test_topic");
+    final Path expectedFile = tempDir.resolve("rejected_gossip_messages").resolve(fileName);
+    assertThat(file.get()).isEqualTo(expectedFile.toString());
+    checkBytesSavedToFile(expectedFile, messageBytes);
+  }
+
+  @Test
+  void saveGossipRejectedMessageToFile_failsToCreateFile(@TempDir Path tempDir) throws IOException {
+    final Bytes messageBytes = dataStructureUtil.stateBuilderPhase0().build().sszSerialize();
+    final String arrivalTimestamp = timeProvider.getTimeInMillis().toString();
+    final Path rejectedGossipMessagesDir = tempDir.resolve("rejected_gossip_messages");
+
+    // Make invalid_blocks directory
+    assertThat(rejectedGossipMessagesDir.toFile().mkdir()).isTrue();
+
+    // Make file with expected name
+    final String fileName = String.format("%s_%s.ssz", arrivalTimestamp, "test_topic");
+    assertThat(rejectedGossipMessagesDir.resolve(fileName).toFile().createNewFile()).isTrue();
+
+    // Should not be able to create file when exists
+    final Optional<String> file =
+        P2PDumpManager.saveGossipRejectedMessageToFile(
+            tempDir, "test_topic", arrivalTimestamp, messageBytes);
+    assertThat(file).isEmpty();
+    checkBytesSavedToFile(rejectedGossipMessagesDir.resolve(fileName), Bytes.EMPTY);
+  }
+
+  @Test
+  void saveInvalidBlockToFile_shouldSaveToFile(@TempDir Path tempDir) {
+    final SignedBeaconBlock block = dataStructureUtil.randomSignedBeaconBlock();
+    final Optional<String> file =
+        P2PDumpManager.saveInvalidBlockToFile(
+            tempDir, block.getSlot(), block.getRoot(), block.sszSerialize());
+    assertThat(file).isPresent();
+
+    final String fileName =
+        String.format(
+            "slot%s_root%s.ssz", block.getSlot(), block.getRoot().toUnprefixedHexString());
+    final Path expectedFile = tempDir.resolve("invalid_blocks").resolve(fileName);
+    assertThat(file.get()).isEqualTo(expectedFile.toString());
+    checkBytesSavedToFile(expectedFile, block.sszSerialize());
+  }
+
+  @Test
+  void saveInvalidBlockToFile_failsToCreateFile(@TempDir Path tempDir) throws IOException {
+    final SignedBeaconBlock block = dataStructureUtil.randomSignedBeaconBlock();
+    final Path invalidBlocksDir = tempDir.resolve("invalid_blocks");
+
+    // Make invalid_blocks directory
+    assertThat(invalidBlocksDir.toFile().mkdir()).isTrue();
+
+    // Make file with expected name
+    final String fileName =
+        String.format(
+            "slot%s_root%s.ssz", block.getSlot(), block.getRoot().toUnprefixedHexString());
+    assertThat(invalidBlocksDir.resolve(fileName).toFile().createNewFile()).isTrue();
+
+    // Should not be able to create file when exists
+    final Optional<String> file =
+        P2PDumpManager.saveInvalidBlockToFile(
+            tempDir, block.getSlot(), block.getRoot(), block.sszSerialize());
+    assertThat(file).isEmpty();
+    checkBytesSavedToFile(invalidBlocksDir.resolve(fileName), Bytes.EMPTY);
+  }
+
+  private void checkBytesSavedToFile(final Path path, final Bytes expectedBytes) {
+    try {
+      final Bytes bytes = Bytes.wrap(Files.readAllBytes(path));
+      assertThat(bytes).isEqualTo(expectedBytes);
+    } catch (IOException e) {
+      fail();
+    }
+  }
+}