EIP-7251 - Added minActivationBalance #8190
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
minActivationBalance impacts how validators are deemed to become active, rather than using MAX_EFFECTIVE_BALANCE A flow on of this is that the max_effective_balance can be changed to the electra max_effective_balance Also it updates epoch processing, and we start seeing electra specific beaconStateAccessors and Predicates. Signed-off-by: Paul Harris <paul.harris@consensys.net>
mehdi-aouadi
approved these changes
Apr 12, 2024
...c/src/main/java/tech/pegasys/teku/spec/logic/versions/electra/helpers/PredicatesElectra.java
Outdated
Show resolved
Hide resolved
...c/src/main/java/tech/pegasys/teku/spec/logic/versions/electra/helpers/PredicatesElectra.java
Outdated
Show resolved
Hide resolved
.../java/tech/pegasys/teku/spec/logic/versions/electra/helpers/BeaconStateAccessorsElectra.java
Outdated
Show resolved
Hide resolved
...ch/pegasys/teku/spec/logic/versions/electra/statetransition/epoch/EpochProcessorElectra.java
Outdated
Show resolved
Hide resolved
fixed missed finals Signed-off-by: Paul Harris <paul.harris@consensys.net>
|
i was less worried about predicates tests, but did add a couple. need to get enough functionality in to be able to run reference tests. |
![github-advanced-security[bot]](https://avatars.githubusercontent.com/in/57789?s=60&v=4){kind=small}
...c/test/java/tech/pegasys/teku/spec/logic/versions/electra/helpers/PredicatesElectraTest.java
Dismissed
Show dismissed
Hide dismissed
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
minActivationBalance impacts how validators are deemed to become active, rather than using MAX_EFFECTIVE_BALANCE A flow on of this is that the max_effective_balance can be changed to the electra max_effective_balance Also it updates epoch processing, and we start seeing electra specific beaconStateAccessors and Predicates.
Documentation
doc-change-requiredlabel to this PR if updates are required.Changelog