Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix PendingPartialWithdrawal deserialization mistake #8195

Merged
merged 2 commits into from
Apr 14, 2024
Merged

Fix PendingPartialWithdrawal deserialization mistake #8195

merged 2 commits into from
Apr 14, 2024

Conversation

jtraglia
Copy link
Contributor

PR Description

This PR adds property tests for the three new "pending*" structures. While doing this, I noticed that createFromBackingNode was returning null which meant sszDeserialize would return null too. The property tests for this structure were failing because of it.

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

StefanBratanov
StefanBratanov approved these changes Apr 13, 2024
View reviewed changes
Copy link
Contributor

@StefanBratanov StefanBratanov left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM. Thanks a lot for these!

@rolfyone
Copy link
Contributor

Thanks, you're ahead of me!

@rolfyone rolfyone merged commit c8a800c into Consensys:master Apr 14, 2024
16 checks passed
@jtraglia jtraglia deleted the fix-ppw-ssz-deserialization branch April 14, 2024 16:04
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@StefanBratanov StefanBratanov StefanBratanov approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@jtraglia @rolfyone @StefanBratanov