Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated GetPayloadV4 with executionRequests decoding #8698

Merged
merged 3 commits into from
Oct 9, 2024
Merged

Updated GetPayloadV4 with executionRequests decoding #8698

merged 3 commits into from
Oct 9, 2024

Conversation

lucassaldanha
Copy link
Member

@lucassaldanha lucassaldanha commented Oct 9, 2024 •
edited
Loading

PR Description

  • Added new executionRequests parameter to GetPayloadResponseV4
  • Using ExecutionRequestsDataCodec to read ExecutionRequests from GetPayloadResponseV4
  • Added optional ExecutionRequests field to GetPayloadResponse, will later be used as part of block processing to process requests.

Fixed Issue(s)

part of #8620

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@lucassaldanha @jtraglia
Update ethereum/executionclient/src/main/java/tech/pegasys/teku/ether…
201b261 
…eum/executionclient/schema/GetPayloadV4Response.java

Co-authored-by: Justin Traglia <95511699+jtraglia@users.noreply.github.com>
jtraglia
jtraglia approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@jtraglia jtraglia left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM 👍 I see no issues.

rolfyone
rolfyone approved these changes Oct 9, 2024
View reviewed changes
Copy link
Contributor

@rolfyone rolfyone left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lucassaldanha lucassaldanha enabled auto-merge (squash) October 9, 2024 21:56
@lucassaldanha lucassaldanha merged commit 21e76dd into Consensys:master Oct 9, 2024
16 of 17 checks passed
@lucassaldanha lucassaldanha deleted the electra-get-payload-v4 branch October 10, 2024 04:42
tbenr pushed a commit to zilm13/teku that referenced this pull request Oct 14, 2024
@lucassaldanha @tbenr
Updated GetPayloadV4 with executionRequests decoding (Consensys#8698)
02b476c
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jtraglia jtraglia jtraglia approved these changes

@rolfyone rolfyone rolfyone approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@lucassaldanha @rolfyone @jtraglia