Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Updated NewPayloadV4 to send requests instead of hash #8710

Merged
merged 1 commit into from
Oct 11, 2024
Merged

Updated NewPayloadV4 to send requests instead of hash #8710

merged 1 commit into from
Oct 11, 2024

Conversation

lucassaldanha
Copy link
Member

PR Description

  • Updated NewPayloadV4 to send requests instead of hash
  • Removed hashing function from codec (not used anymore)
  • Moved initialization of codec to SpecLogicElectra

Fixed Issue(s)

part of #8620

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

gfukushima
gfukushima approved these changes Oct 11, 2024
View reviewed changes
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, may this be the final change of this saga....

@lucassaldanha lucassaldanha merged commit bc3a5e7 into Consensys:master Oct 11, 2024
17 checks passed
@lucassaldanha lucassaldanha deleted the new-paylaod-v4-update branch October 11, 2024 00:13
tbenr pushed a commit to zilm13/teku that referenced this pull request Oct 14, 2024
@lucassaldanha @tbenr
Updated NewPayloadV4 to send requests instead of hash (Consensys#8710)
b0254c2
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gfukushima gfukushima gfukushima approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@lucassaldanha @gfukushima