Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Ephemery startup network determination #8781

Merged
merged 5 commits into from
Nov 5, 2024

Conversation

rolfyone
Copy link
Contributor

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

fixes Consensys#8777

Signed-off-by: Paul Harris <paul.harris@consensys.net>
…tly to ephemery network

Previously we were using a combination of a contract id and the chain id changing, but this improves the situation by explicitly considering the ephemery network.

Signed-off-by: Paul Harris <paul.harris@consensys.net>
@rolfyone rolfyone changed the title Ephemery startup test Ephemery startup network determination Oct 24, 2024
Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm

@rolfyone rolfyone enabled auto-merge (squash) November 5, 2024 21:18
@rolfyone rolfyone merged commit 5eda7f3 into Consensys:master Nov 5, 2024
17 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants