Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

use correct schema definitions when creation full beacon block #8806

Merged

Conversation

mehdi-aouadi
Copy link
Contributor

@mehdi-aouadi mehdi-aouadi commented Oct 31, 2024

PR Description

Update the DataStructureUtil to use the correct schema definitions when generating attestations for full beacon blocks.
This is required in #8800 in order to make the DataStructureUtil use the correct schema definition when generating AttesterSlashings and Attestations related data when dealing with fork aware spec in the tests.

Fixed Issue(s)

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

@mehdi-aouadi mehdi-aouadi mentioned this pull request Oct 31, 2024
2 tasks
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@mehdi-aouadi mehdi-aouadi enabled auto-merge (squash) November 4, 2024 13:07
@mehdi-aouadi mehdi-aouadi merged commit e8289f1 into Consensys:master Nov 4, 2024
17 checks passed
@mehdi-aouadi mehdi-aouadi deleted the ds-utils-full-beacon-block branch November 4, 2024 13:56
mehdi-aouadi added a commit that referenced this pull request Nov 4, 2024
* Decouple block and blobs publishing\import (#8728)

* use correct schema definitions when creation full beacon block (#8806)

* use correct schema definitions when creation full beacon block

* use forkChoiceUpdatedV4 with PayloadAttributesV4 (#8752) (#8799)

---------

Co-authored-by: Enrico Del Fante <enrico.delfante@consensys.net>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants