Skip to content

Improve logging during sync #9244

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
merged 21 commits into from
Mar 25, 2025

Conversation

StefanBratanov
Copy link
Contributor

@StefanBratanov StefanBratanov commented Mar 17, 2025

Adds chain target information on the main Syncing event
Adds a new Sync Info event with additional info from the internal BatchSync class

PR Description

Fixed Issue(s)

fixes #9220

Documentation

  • I thought about documentation and added the doc-change-required label to this PR if updates are required.

Changelog

  • I thought about adding a changelog entry, and added one if I deemed necessary.

Copy link
Contributor

@gfukushima gfukushima left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

lgtm, with a question on the return of SyncManager::getSyncStatus

@tbenr
Copy link
Contributor

tbenr commented Mar 18, 2025

let's put this LOG back to debug too

return findCommonAncestor(latestFinalizedSlot, targetChain)
.thenPeek(ancestor -> LOG.info("Found common ancestor at slot {}", ancestor));

@tbenr tbenr added the DO NOT MERGE Not ready to merge label Mar 19, 2025
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

I added an experimental change to the PR, adding more info taken from the BatchSync.
It is not good in the current form but we can play with it until we find the final form.

@tbenr tbenr force-pushed the improve_logging_sync branch from 8be0071 to a79fcf0 Compare March 19, 2025 18:30
@StefanBratanov
Copy link
Contributor Author

Hoodi syncing

image

@StefanBratanov StefanBratanov removed the DO NOT MERGE Not ready to merge label Mar 21, 2025
@StefanBratanov StefanBratanov force-pushed the improve_logging_sync branch 2 times, most recently from d81a456 to eb75e8b Compare March 22, 2025 14:25
@StefanBratanov StefanBratanov requested a review from tbenr March 22, 2025 14:56
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

looks nice. we need unit tests now.

@StefanBratanov StefanBratanov requested a review from tbenr March 24, 2025 20:28
Copy link
Contributor

@tbenr tbenr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@StefanBratanov StefanBratanov enabled auto-merge (squash) March 25, 2025 08:27
@StefanBratanov StefanBratanov merged commit c9fe784 into Consensys:master Mar 25, 2025
16 checks passed
@StefanBratanov StefanBratanov deleted the improve_logging_sync branch March 25, 2025 12:13
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Improve logging/reporting during sync
3 participants