Skip to content

[NOCI] Bot Check Fix #365

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
jjl014 merged 1 commit into from
Jan 9, 2025
Merged

[NOCI] Bot Check Fix #365

jjl014 merged 1 commit into from
Jan 9, 2025

Conversation

@jjl014
Copy link
Contributor

@jjl014 jjl014 commented Jan 9, 2025 •
edited
Loading

Updates:

  • Switch to use dynamic helper instead of depending on the instance state for determining human-ness. The session storage variable should be the source of truth

@jjl014 jjl014 requested a review from a team January 9, 2025 01:10
mocca102
mocca102 approved these changes Jan 9, 2025
View reviewed changes
Copy link
Contributor

@mocca102 mocca102 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks good to me but lets get a second review

@jjl014 jjl014 merged commit 1949f37 into master Jan 9, 2025
7 of 8 checks passed
@jjl014 jjl014 deleted the noci-bot-check-fix branch January 9, 2025 19:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Reviewers

@esezen esezen esezen approved these changes

@mocca102 mocca102 mocca102 approved these changes

Assignees

No one assigned

Labels

None yet

Projects

None yet

Milestone

No milestone

Development

Successfully merging this pull request may close these issues.

4 participants

@jjl014 @esezen @mocca102