[NOCI] TrackConversion - Remove Result ID from Docs #377
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
mocca102
requested changes
May 30, 2025
Contributor
mocca102
left a comment
mocca102
left a comment
There was a problem hiding this comment.
I believe we wanted to remove it from trackConversion example.
Also we don't need to remove it from docs/ files these are automatically generated.
Lets not remove the parameter from recommendations tracking methods in case a customer uses them
This reverts commit 79a5d83.
Contributor
Author
Honestly I'm not even sure how I accidentally removed it from track Recs instead of conversions. I've fixed it now, thank you for catching that |
mocca102
approved these changes
Jul 23, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing result ID from the docs since it isn't used in the track conversion call