[CDX-210] Add support for seedItemIds in trackRecommendationClick #395
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jjl014
approved these changes
Aug 15, 2025
Contributor
jjl014
left a comment
jjl014
left a comment
There was a problem hiding this comment.
LGTM! 🚀 Just left a minor comment
| * @param {number} [networkParameters.timeout] - Request timeout (in milliseconds) | ||
| * @param {string} [parameters.slCampaignId] - Pass campaign id of sponsored listing | ||
| * @param {string} [parameters.slCampaignOwner] - Pass campaign owner of sponsored listing | ||
| * @param {string[]|string|number} [parameters.seedItemIds] - Item ID(s) to be used as seed |
Contributor
There was a problem hiding this comment.
should we keep this as string[]|string to stay consistent with the results fn?
EDIT: Nvm, it looks like we did this for the view event as well. Feel free to ignore.
Contributor
Author
There was a problem hiding this comment.
I actually made it just string[] at first to have a tighter type but we already used this type in view event so I didn't want to make it inconsistent
Contributor
There was a problem hiding this comment.
Haha. I was thinking of having it just be string[] as well when I first looked over things, but makes sense to leave it to keep things consistent with the other event
esezen
deleted the
cdx-210-client-javascript-add-optional-seed-item-ids-to-resulyts
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Purpose
Adds optional
seedItemIdsparameter to strengthen recommendation tracking by providing seed item.Changes Made
Implementation
#375