Skip to content

Add metadata field to results_config response #396

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
esezen merged 4 commits into from
Sep 8, 2025
Merged

Add metadata field to results_config response #396

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
4 commits
Select commit Hold shift + click to select a range
be9ef90
Add metadata field to results_config response
vladconstructor Aug 13, 2025
4804198
adjust tests
vladconstructor Aug 26, 2025
f47ae3c
Merge branch 'master' of https://github.com/Constructor-io/constructo…
vladconstructor Aug 26, 2025
f31e907
Remove internal types
vladconstructor Aug 26, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
2 changes: 2 additions & 0 deletions spec/src/modules/quizzes.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -548,6 +548,7 @@ describe(`ConstructorIO - Quizzes${bundledDescriptionSuffix}`, () => {
expect(res).to.have.property('quiz_version_id').to.be.an('string');
expect(res).to.have.property('quiz_id').to.be.an('string');
expect(res).to.have.property('results_config').to.be.an('object');
expect(res).to.have.property('metadata').to.be.an('object');
});
});

Expand All @@ -564,6 +565,7 @@ describe(`ConstructorIO - Quizzes${bundledDescriptionSuffix}`, () => {
const requestedUrlParams = helpers.extractUrlParamsFromFetch(fetchSpy);

expect(res).to.have.property('results_config').to.be.an('object');
expect(res).to.have.property('metadata').to.be.an('object');
expect(res).to.have.property('quiz_version_id').to.be.an('string').to.equal(quizVersionId);
expect(res).to.have.property('quiz_id').to.be.an('string');
expect(fetchSpy).to.have.been.called;
Expand Down
2 changes: 2 additions & 0 deletions src/types/quizzes.d.ts
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -123,6 +123,7 @@ export interface BaseQuestion extends Record<string, any> {
description: string;
cta_text: Nullable<string>;
images?: Nullable<QuestionImages>;
is_skippable: Boolean;
}

export interface FilterValueQuestion extends BaseQuestion {
Expand Down Expand Up @@ -188,6 +189,7 @@ export interface QuizResultsConfig extends Record<string, any> {
}

export interface QuizResultsConfigResponse extends Record<string, any> {
metadata: Nullable<object>,
results_config: QuizResultsConfig,
quiz_version_id: string;
quiz_id: string;
Expand Down
Loading