[CDX-361] Fix lint

[esezen]

Lint was failing due to version mismatch

[Copilot]

Pull request overview

This PR fixes linting issues by updating the ESLint version and addressing code style violations. The changes ensure compliance with the updated linting rules by making references to the global location object more explicit and reformatting code to meet line length requirements.

Changes:

• Updated ESLint from version 8.23.1 to 8.57.0
• Replaced bare location references with explicit window.location references
• Reformatted long lines to comply with line length requirements

Reviewed changes

Copilot reviewed 3 out of 4 changed files in this pull request and generated no comments.

File	Description
package.json	Updated ESLint dependency version from ^8.23.1 to ^8.57.0
src/utils/shopifyDefaults.ts	Changed bare location references to window.location and improved string template formatting
src/bundled.jsx	Split long ternary expression across multiple lines for better readability

---

💡 Add Copilot custom instructions for smarter, more guided reviews. Learn how to get started.

[constructor-claude-bedrock]

Code Review Results

✅ Strengths

The PR successfully addresses the lint failure by upgrading ESLint from 8.23.1 to 8.57.0, and includes proper code formatting improvements that enhance consistency and readability.

🚨 Critical Issues

None

⚠️ Important Issues

None

💡 Suggestions

File: src/bundled.jsx Line: 11-12
The line-breaking for the containerSelector variable is good for readability. This formatting change improves code maintainability.

File: src/utils/shopifyDefaults.ts Line: 30, 33
Good improvement replacing location.origin and location.search with window.location.origin and window.location.search. This makes the code more explicit and consistent throughout the file.

File: src/utils/shopifyDefaults.ts Line: 65
The template literal change from string concatenation (location.origin + shopifySearchUrl + '?' + queryParams.toString()) to template literals (${window.location.origin + shopifySearchUrl}?${queryParams.toString()}) improves readability and is more modern JavaScript.

Package updates:
The ESLint upgrade from 8.23.1 to 8.57.0 brings in several dependency updates:

• @eslint/eslintrc from 1.4.0 to 2.1.4
• @humanwhocodes/config-array from 0.11.8 to 0.13.0
• @humanwhocodes/object-schema from 1.2.1 to 2.0.3
• espree from 9.4.1 to 9.6.1
• esquery from 1.4.0 to 1.7.0
• optionator from 0.9.1 to 0.9.4
• Replaces grapheme-splitter with graphemer (1.4.0)
• Removes js-sdsl dependency (no longer needed)
• Adds @eslint-community/regexpp (4.12.2)
• Adds @eslint/js (8.57.1)
• Adds @ungap/structured-clone (1.2.0)

All of these are internal ESLint dependencies that are properly managed through the package-lock.json file.

Overall Assessment: ✅ Pass

This PR correctly addresses the lint failure caused by version mismatch. The changes are minimal, focused, and include positive code style improvements. The ESLint upgrade is a minor version bump within the same major version, minimizing risk of breaking changes. No security vulnerabilities or code quality issues were identified.