Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

codespell: config, workflow and typos fixed #93

Merged
merged 7 commits into from
Aug 21, 2023

Conversation

yarikoptic
Copy link
Contributor

was just looking around ;-)

=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w || :",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
=== Do not change lines below ===
{
 "chain": [],
 "cmd": "codespell -w -i 3 -C 2",
 "exit": 0,
 "extra_inputs": [],
 "inputs": [],
 "outputs": [],
 "pwd": "."
}
^^^ Do not change lines above ^^^
@jeremymanning
Copy link
Member

Thanks @yarikoptic, these are great!

@jeremymanning
Copy link
Member

jeremymanning commented Aug 17, 2023

@yarikoptic can we add "covert attention" (paper title, correct as written) and "dateset" (latex command, correct as written) to some sort of "ignore" list for code spell? otherwise that check is just going to fail every time...

It is a bit less reliable/tricky to add phrases so I decided to just ignore all instances of such words
@yarikoptic
Copy link
Contributor Author

done! odd that I didn't pick that up locally

Copy link
Member

@paxtonfitzpatrick paxtonfitzpatrick left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This looks great, thanks @yarikoptic! I tend to ignore/disable my IDE's spellchecker (as you can see 🙃) because it's so sensitive, so this seems like a good compromise. Also impressed with how quick the action ran!

@paxtonfitzpatrick paxtonfitzpatrick merged commit 4a3be14 into ContextLab:main Aug 21, 2023
13 checks passed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants