-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Security Controls Action Documentation #8
base: main
Are you sure you want to change the base?
Conversation
@@ -49,6 +49,9 @@ groups: | |||
- id: ognl-execution | |||
value: "ognl-execution" | |||
brief: "Object-Graph Navigation Language expression execution." | |||
- id: security-control |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
in my first attempt at creating custom attributes on top of otel standards I made a mistake. I should have namespaced the custom attributes by prefixing them all with contrast-
or contrast.
. It would be weird to do that now so we can probably continue without the namespace for this changeset and I'll just have to fix it later with a new standard convention release at some point in the future.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
the change looks ok to me. Let me know if you need help with getting the pipeline passing before merging this to main.
https://contrast.atlassian.net/browse/PROD-2372
Changes
Documenting new Observe action:
security-control
. The following attributes were discussed with Brian Sowers.security.control.method
: Requiredsecurity.control.name
: Optionalsecurity.control.rules
: Recommendedsecurity.control.type
: OptionalNote: if the PR is touching an area that is not listed in the
existing areas,
or the area does not have sufficient
domain experts coverage,
the PR might be tagged as experts needed
and move slowly until experts are identified.
Merge requirement checklist