fix: encode calldata in preflight gas estimation#205
Open
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Open
fix: encode calldata in preflight gas estimation#205haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Conversation
The preflight() function passed data: undefined to estimateGas(), which estimates gas for a plain ETH transfer rather than the actual contract call. This always fails for contract interactions, falling through to the catch() fallback of 200,000 gas. The balance check then uses an inaccurate estimate, providing no real protection against out-of-gas reverts. Encode the calldata with encodeFunctionData() so estimateGas() simulates the actual contract call and returns a meaningful estimate. Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
preflight()insrc/registry/erc8004.tspassesdata: undefinedtoestimateGas()catch()fallback of 200,000 gasencodeFunctionData()from viem to encode the actual calldata before gas estimationTest plan
npx tsc --noEmitpasses🤖 Generated with Claude Code