fix: use numeric status code for 403 detection in Conway client#206
Open
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Open
fix: use numeric status code for 403 detection in Conway client#206haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
haosenwang1018 wants to merge 1 commit intoConway-Research:mainfrom
Conversation
The 403 auth-failure guards in exec(), writeFile(), and readFile()
matched err?.message?.includes("403") against the error message
string. This is fragile: any error whose message coincidentally
contains "403" (e.g., port 4030, or a response body mentioning 403)
would be misclassified as an authentication failure.
Since request() already sets err.status to the numeric HTTP status
code (line 69), use err?.status === 403 for reliable detection.
Co-Authored-By: Claude Sonnet 4.6 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
exec(),writeFile(), andreadFile()insrc/conway/client.tsdetect 403 auth failures by matchingerr?.message?.includes("403")against the error message stringrequest()already setserr.statusto the numeric HTTP status code (line 69), the fix useserr?.status === 403for reliable detectionTest plan
npx tsc --noEmitpasses🤖 Generated with Claude Code