Skip to content

fix(renderer): check all assistant messages for loop signals in Ralph and Lisa logic #336

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Merged
idofrizler merged 1 commit into from
Feb 11, 2026
Merged

fix(renderer): check all assistant messages for loop signals in Ralph and Lisa logic #336

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions package-lock.json
View file
Open in desktop

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

30 changes: 22 additions & 8 deletions src/renderer/App.tsx
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -1500,8 +1500,12 @@ const App: React.FC = () => {

// Check for Ralph loop continuation
if (tab?.ralphConfig?.active) {
const lastMessage = tab.messages[tab.messages.length - 1];
const hasCompletionPromise = lastMessage?.content?.includes(RALPH_COMPLETION_SIGNAL);
// Check ALL assistant messages for the completion signal, not just the last one.
// A single agent turn can produce multiple assistant.message events (between tool calls),
// and the signal may be in an earlier message, not the final one.
const hasCompletionPromise = tab.messages.some(
(msg) => msg.role === 'assistant' && msg.content?.includes(RALPH_COMPLETION_SIGNAL)
);
const maxReached = tab.ralphConfig.currentIteration >= tab.ralphConfig.maxIterations;

if (!hasCompletionPromise && !maxReached) {
Expand All @@ -1517,7 +1521,10 @@ const App: React.FC = () => {
// If clearContextBetweenIterations is true, we provide minimal context (like Gemini Ralph)
// and instruct the agent to re-read files for state (reduces context pollution)
const clearContext = tab.ralphConfig.clearContextBetweenIterations ?? true;
const lastResponseContent = lastMessage?.content || '';
const lastAssistantMsg = [...tab.messages]
.reverse()
.find((m) => m.role === 'assistant');
const lastResponseContent = lastAssistantMsg?.content || '';

let continuationPrompt: string;

Expand Down Expand Up @@ -1640,11 +1647,18 @@ Only output ${RALPH_COMPLETION_SIGNAL} when ALL items above are verified complet

// Check for Lisa Simpson loop continuation
if (tab?.lisaConfig?.active) {
const lastMessage = tab.messages[tab.messages.length - 1];
const lastContent = lastMessage?.content || '';
const hasPhaseComplete = lastContent.includes(LISA_PHASE_COMPLETE_SIGNAL);
const hasReviewApprove = lastContent.includes(LISA_REVIEW_APPROVE_SIGNAL);
const hasReviewReject = lastContent.includes(LISA_REVIEW_REJECT_PREFIX);
// Check ALL recent assistant messages for phase signals, not just the last one.
// Same rationale as Ralph: multi-message turns may have signals in earlier messages.
const recentAssistantMessages = tab.messages.filter((msg) => msg.role === 'assistant');
const hasPhaseComplete = recentAssistantMessages.some((msg) =>
msg.content?.includes(LISA_PHASE_COMPLETE_SIGNAL)
);
const hasReviewApprove = recentAssistantMessages.some((msg) =>
msg.content?.includes(LISA_REVIEW_APPROVE_SIGNAL)
);
const hasReviewReject = recentAssistantMessages.some((msg) =>
msg.content?.includes(LISA_REVIEW_REJECT_PREFIX)
);
const currentPhase = tab.lisaConfig.currentPhase;
const currentVisitCount = tab.lisaConfig.phaseIterations[currentPhase] || 1;

Expand Down