Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Windows compatibility update #2839

Open
wants to merge 2 commits into
base: master
Choose a base branch
from
Open

Conversation

esa-coorp
Copy link
Contributor

Detailed purpose of the PR

Result and observation

  • Breaking changes ?
    If checked, what have you broken ?

  • Extra lib ?
    If checked, Which extra lib did you add ? (name, purpose, link ...).

Testing Strategy

  • Already covered by tests
  • Manual testing
  • Unit testing

@esa-coorp esa-coorp requested review from adamska27 and HuyIT9898 April 9, 2024 13:41
@esa-coorp esa-coorp self-assigned this Apr 9, 2024
Copy link

codecov bot commented Apr 9, 2024

Codecov Report

All modified and coverable lines are covered by tests ✅

Project coverage is 94.55%. Comparing base (c8fad63) to head (169a61d).
Report is 3 commits behind head on master.

Additional details and impacted files

Impacted file tree graph

@@            Coverage Diff             @@
##           master    #2839      +/-   ##
==========================================
- Coverage   95.40%   94.55%   -0.85%     
==========================================
  Files         428      384      -44     
  Lines        6828     5769    -1059     
  Branches      401      401              
==========================================
- Hits         6514     5455    -1059     
  Misses        249      249              
  Partials       65       65              

see 44 files with indirect coverage changes


Continue to review full report in Codecov by Sentry.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 7b42bf3...169a61d. Read the comment docs.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants