-
Notifications
You must be signed in to change notification settings - Fork 2
Mimic mdBook
implementation 🎁
#79
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Conversation
Switch from `lazy_static::lazy_static` to `once_cell::sync::lazy` And, it includes the fix for #78
Warning Rate Limit Exceeded@CoralPink has exceeded the limit for the number of commits or files that can be reviewed per hour. Please wait 21 minutes and 31 seconds before requesting another review. How to resolve this issue?After the wait time has elapsed, a review can be triggered using the We recommend that you space out your commits to avoid hitting the rate limit. How do rate limits work?CodeRabbit enforces hourly rate limits for each developer per organization. WalkthroughThe Changes
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (invoked as PR comments)
Additionally, you can add CodeRabbit Configration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Review Status
Actionable comments generated: 1
Configuration used: CodeRabbit UI
Files ignored due to path filters (2)
rs/mdbook-footnote/Cargo.lock
is excluded by:!**/*.lock
rs/mdbook-footnote/Cargo.toml
is excluded by:!**/*.toml
Files selected for processing (1)
- rs/mdbook-footnote/src/lib.rs (2 hunks)
Additional comments: 2
rs/mdbook-footnote/src/lib.rs (2)
- 5-6: The change from
lazy_static
toonce_cell::sync::Lazy
forFOOTNOTE_RE
is correctly implemented.- 37-42: > 📝 NOTE
This review was outside the diff hunks and was mapped to the diff hunk with the greatest overlap. Original lines [9-39]
The logic within the
replacing
function appears to be correct and uses theFOOTNOTE_RE
regex as intended. Ensure that the changes to the regex initialization do not affect the behavior of this function.
Co-authored-by: coderabbitai[bot] <136622811+coderabbitai[bot]@users.noreply.github.com>
Thanks for pointing that out! 🥕 Okay, merge! |
Equivalent to the following. refs: CoralPink/commentary#79 (comment)
Switch from
lazy_static::lazy_static
toonce_cell::sync::lazy
And, it includes the fix for #78.
(I don't know why, but I can't pass the #78 check, so I will merge it through this PR just to be safe...)
Summary by CodeRabbit