Migration from Vue/Nuxt/Vuetify v2 to v3#186
Open
bryantpark04 wants to merge 44 commits intoCornellDataScience:mainfrom
Open
Migration from Vue/Nuxt/Vuetify v2 to v3#186bryantpark04 wants to merge 44 commits intoCornellDataScience:mainfrom
bryantpark04 wants to merge 44 commits intoCornellDataScience:mainfrom
Conversation
They might be broken
- Refactor FooterContacts into component - Turn copyright statement into a v-row
- Remove dynamic imports - they don't work in Vue 3 anymore. I can't believe the error handling was so bad... THE DYNAMIC REQUIRE WAS THE GODDAMN ISSUE - Move image to public folder
Revisit automatic dark mode switching at a later point
Other padding/margin adjustments Make apply button purple and bold
Kind of confusing
✅ Deploy Preview for cornelldatascience ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cornelldatascience1 ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
Add Contact button to mobile navbar
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
No description provided.