feat: Add ICS20 TransferV2 #2317
Open
+582
−67
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
2 tasks
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
from
a1910c3 to
0031a25
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
from
c02e541 to
2288ae6
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
6 times, most recently
from
8622495 to
2c6e84d
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
from
2c6e84d to
40b1383
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
4 times, most recently
from
bf68aef to
e934799
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
4 times, most recently
from
9a7f3f5 to
3714b3a
Compare
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
from
3714b3a to
39179ac
Compare
chipshort
reviewed
Jan 31, 2025
contracts/ibc-callbacks/src/msg.rs
Outdated
| @@ -20,6 +20,8 @@ pub enum ExecuteMsg { | |||
| /// Who should receive callbacks for the message | |||
| #[serde(default)] | |||
| callback_type: CallbackType, | |||
| /// IBC channel version | |||
| channel_version: String, | |||
There was a problem hiding this comment.
nit: Wouldn't an enum be nicer?
packages/std/src/ibc.rs
Outdated
| @@ -4,6 +4,7 @@ | |||
| use core::cmp::{Ord, Ordering, PartialOrd}; | |||
| use schemars::JsonSchema; | |||
| use serde::{Deserialize, Serialize}; | |||
| use std::vec; | |||
| pub struct WithMemo { | ||
| memo: String, | ||
| pub memo: String, |
There was a problem hiding this comment.
Couldn't we keep them pub(crate)?
| /// Adds forwarding data. | ||
| /// It is worth to notice that the builder does not allow to add forwarding data along with | ||
| /// callbacks. It is discouraged in the IBC docs: | ||
| /// https://github.com/cosmos/ibc-go/blob/main/docs/docs/04-middleware/02-callbacks/01-overview.md#known-limitations |
There was a problem hiding this comment.
Can we link to the rendered docs instead? https://ibc.cosmos.network/v9/middleware/callbacks/overview/#known-limitations Just a bit nicer to read
Comment on lines
107
to
108
| /// It is worth to notice that the builder does not allow to add forwarding data along with | ||
| /// callbacks. It is discouraged in the IBC docs: |
There was a problem hiding this comment.
The IBC docs specifically mention source callbacks. Destination callbacks are fine.
Can we allow that combination forwarding + destination callback in the builder?
kulikthebird
force-pushed
the
tkulik/feat/ibc_transfer_v2
branch
from
4a4172f to
a1b922e
Compare
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.