Merge pull request #1904 from CosmWasm/mark-query-deterministic

Mark QuerySmart contract error as deterministic
CosmWasm · Jun 19, 2024 · ff0a43b · ff0a43b
2 parents de9c002 + 5465e8c
commit ff0a43b
Show file tree

Hide file tree

Showing 3 changed files with 38 additions and 3 deletions.
diff --git a/x/wasm/keeper/contract_keeper_test.go b/x/wasm/keeper/contract_keeper_test.go
@@ -14,8 +14,10 @@ import (
 
 	sdk "github.com/cosmos/cosmos-sdk/types"
 
+	"github.com/CosmWasm/wasmd/x/wasm/keeper/testdata"
 	"github.com/CosmWasm/wasmd/x/wasm/keeper/wasmtesting"
 	"github.com/CosmWasm/wasmd/x/wasm/types"
+	wasmvmtypes "github.com/CosmWasm/wasmvm/v2/types"
 )
 
 func TestInstantiate2(t *testing.T) {
@@ -169,3 +171,36 @@ func TestInstantiate2(t *testing.T) {
 		})
 	}
 }
+
+func TestQuerierError(t *testing.T) {
+	parentCtx, keepers := CreateTestInput(t, false, AvailableCapabilities)
+	parentCtx = parentCtx.WithGasMeter(storetypes.NewInfiniteGasMeter())
+
+	contract := InstantiateReflectExampleContract(t, parentCtx, keepers)
+
+	// this query will fail in the contract because there is no such reply
+	erroringQuery := testdata.ReflectQueryMsg{
+		SubMsgResult: &testdata.SubCall{
+			ID: 1,
+		},
+	}
+	// we make the reflect contract run the erroring query to check if our error stays
+	queryType := testdata.ReflectQueryMsg{
+		Chain: &testdata.ChainQuery{
+			Request: &wasmvmtypes.QueryRequest{
+				Wasm: &wasmvmtypes.WasmQuery{
+					Smart: &wasmvmtypes.SmartQuery{
+						ContractAddr: contract.Contract.String(),
+						Msg:          mustMarshal(t, erroringQuery),
+					},
+				},
+			},
+		},
+	}
+	query := mustMarshal(t, queryType)
+	_, err := keepers.WasmKeeper.QuerySmart(parentCtx, contract.Contract, query)
+	require.Error(t, err)
+
+	// we expect the contract's "reply 1 not found" to be in there
+	assert.Contains(t, err.Error(), "reply 1 not found")
+}
diff --git a/x/wasm/keeper/keeper.go b/x/wasm/keeper/keeper.go
@@ -799,7 +799,7 @@ func (k Keeper) QuerySmart(ctx context.Context, contractAddr sdk.AccAddress, req
 		return nil, errorsmod.Wrap(types.ErrVMError, qErr.Error())
 	}
 	if queryResult.Err != "" {
-		return nil, errorsmod.Wrap(types.ErrQueryFailed, queryResult.Err)
+		return nil, types.MarkErrorDeterministic(errorsmod.Wrap(types.ErrQueryFailed, queryResult.Err))
 	}
 	return queryResult.Ok, nil
 }

diff --git a/x/wasm/keeper/recurse_test.go b/x/wasm/keeper/recurse_test.go
@@ -263,8 +263,8 @@ func TestLimitRecursiveQueryGas(t *testing.T) {
 			},
 			expectQueriesFromContract: 10,
 			expectOutOfGas:            false,
-			expectError:               "query wasm contract failed", // Error we get from the contract instance doing the failing query, not wasmd
-			expectedGas:               10*(GasWork2k+GasReturnHashed) - 249,
+			expectError:               "query wasm contract failed",          // Error we get from the contract instance doing the failing query, not wasmd
+			expectedGas:               10*(GasWork2k+GasReturnHashed) + 3124, // lots of additional gas for long error message
 		},
 	}